- Issue created by @altcom_neil
- First commit to issue fork.
- 🇩🇪Germany Anybody Porta Westfalica
I think this is important now, as it blocks update to latest versions. Thanks!
- First commit to issue fork.
- 🇩🇪Germany Christian.wiedemann
Hi,
I am not sure if we have more breaking changes with the 4.x branch of gin. I checked it right now and it looks "good" for me.
But maybe you have more expierence. Should I create a new 2.0.x branch to support gin 4? What do you think? - 🇺🇸United States kmonty San Francisco, CA
I think it would be helpful to create a 2.x branch, even if it is in alpha state, so folks can test it more. Given the scope of published breaking changes, I don't see a reason that gin_lb wouldn't be compatible as-is.
I was going to spend some time testing this today, as there some issues with the sticky nav and our Layout Builder setup that we are encountering, but we cannot even upgrade to the latest release of Gin without manually hacking our composer lockfile.
- 🇺🇸United States mpotter
I definitely support creating a new branch so this change can be merged and then tested since people can't really apply a patch to a module's composer.json.
The alternative would be to update the main 1.x-dev branch with a more complex composer.json requirement that would allow gin_lb to be installed with either gin 3.x OR 4.x if you don't expect a lot of needed changes.
-
christian.wiedemann →
committed ce592997 on 2.0.x authored by
shivam_tiwari →
Issue #3498755 by shivam_tiwari, joelpittet: Support for Gin Admin Theme...
-
christian.wiedemann →
committed ce592997 on 2.0.x authored by
shivam_tiwari →
- 🇩🇪Germany Anybody Porta Westfalica
Thank you very much @christian.wiedemann! :) Happy to give it a try.
-
christian.wiedemann →
committed e9675f62 on 2.0.x authored by
shivam_tiwari →
Issue #3498755 by shivam_tiwari, joelpittet: Support for Gin Admin Theme...
-
christian.wiedemann →
committed e9675f62 on 2.0.x authored by
shivam_tiwari →
- Status changed to Fixed
2 months ago 8:24pm 12 March 2025 Automatically closed - issue fixed for 2 weeks with no activity.