- Issue created by @Ujjval Kumar Jha
- Merge request !591Gin Settings Using static text that does not support translation. → (Open) created by shivam_tiwari
- 🇮🇳India Ujjval Kumar Jha
@shivam_tiwari I notice there is one space before span tag previously but you missed it
because if you check the original line where all these variable is usedExample:
$this->t('New Drupal Navigation, Test integration') . $new_label . $experimental_label,Based on your code now there is no space between them
So may be need to correct it
Thanks
- 🇨🇭Switzerland saschaeggi Zurich
I move this back to needs work as the phpunit tests are failing, see https://git.drupalcode.org/issue/gin-3508553/-/jobs/4490177
I don't think
$this->
will work in this context - 🇨🇭Switzerland saschaeggi Zurich
The use of
$this
still needs to be checked here - 🇮🇳India shivam_tiwari
@saschaeggi Please verify now. I updated MR according to your suggestions.