Don't render icons for admin links that aren't there

Created on 1 April 2025, 25 days ago

Steps to reproduce

Log in as user with limited privileges, e.g., no user management capabilities. Note that although the 'People' link is not present in the toolbar, the icons are still there.

🐛 Bug report
Status

Active

Version

4.0

Component

User interface

Created by

🇺🇸United States rubymuse

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @rubymuse
  • 🇮🇳India Tirupati_Singh

    I'm looking into it.

  • Pipeline finished with Success
    18 days ago
    #469206
  • 🇮🇳India Tirupati_Singh

    Hi @rubymuse, I've fixed the rendering issue for the menu icons for which the user has no permission. Now the menu icons along the menu link will be rendered as per the logged user's role permission. I've allowed some administrative permission to the logged-in user role and now the menu icons are being shown as per the role as shown in the screenshot. I'm attaching screenshots of the before and after fixes of the issue. Please review the changes.

    Thanks!

  • 🇮🇳India snehal-chibde

    hello @tirupati_singh, I have reviewed your MR, in Gin theme Version 4.0.x. Created a new user with role as 'Content Editor', logged in to the user account. The menu is working as expected now with no extra icons being shown.
    Added a before and after screenshot for reference.

  • 🇮🇳India shivam_tiwari

    I checked it from my side also, and it is working as expected. This is basic thing: if there is no menu item for any user, then icons should not be visible for that user. As there is no pipeline failure and test cases issue with MR, moving it to RTBC.
    I am adding some screenshots here related to my unit testing.

Production build 0.71.5 2024