🇺🇸United States @mmenavas

My site is also frozen at 10.2.7. Let us know how the community can help out.

Reroll of patch #2 compatible with 8.x-1.11.

I'm experiencing this issue consistently when I try to a link to embedded images (e.g. elements). Do your advanced attributes (e.g. id, class, etc.) get saved? In my case, they don't. I think this issue might be related to lack of support for embedded entities as reported on https://www.drupal.org/project/editor_advanced_link/issues/3349389 🐛 Link attributes don't save Needs review .

Hi @mattsqd! Thank you for making a PR! I tested your code on one of my Drupal 10 sites, and it works as expected. I was able to change the moderation state for all of my view results. I also tested updating the moderation state for a few items I selected, and that also worked well.

Here's an updated patch that combines @andikanio's suggestion as a database update hook and @sarwan_verma's patch.

mmenavas → created an issue.

I got the same error message when I was trying to preview a new node that had content moderation enabled. The source of the issue was a bug 🐛 Had an issue with preview button Needs work in the workflow_buttons → module.

Patch for 2.0.x.

mmenavas → created an issue.

Tested patch #14 and it is working fine. RTBC+1

Thanks for pointing out that D10 compatible modules should use getContentTypeFormat instead of getContentType. I pushed a commit to my MR to resolve this issue (the fixed is based on https://www.drupal.org/project/drupal/issues/3306886 → ), Unfortunately my patch makes use of PHP 8 features that are not available in PHP 7, so that makes my patch only compatible with D9 and D10. Feel free to close the issue if you think any development/reviewing effort should be spent on making the 3.x stable. As you pointed out before, tb_megamenu users who still wish to use the 8.x-1.x branch on D10 sites can use the lenient composer plugin along with my patch.

@themodularlab: Thanks for the background info. Sorry I updated the status of this issue before seeing your comment. I think it makes sense to make the release compatible with Drupal 8 since the branch name is 8.x-1.x. Should the code be compatible with PHP 7.4 too?

mmenavas → created an issue.

Posting new patch as the pervious one wasn't working for me.

Thank you for merging the MR and for pointing out the correct way to commit code. I will follow that from now on so everyone involved in the issue can get credit.

Attempt to fix this issue on 8.x-1.x branch.

mmenavas → created an issue.

@swatidhurandhar: I recently experienced this issue again on another site after upgrading from D9 to D10. I used the Seven theme and CKEditor module from contrib space as they're not available on core anymore. When I open the table properties modal and hover over the alignment dropdown, I see multiple arrows as shown on the screenshot.

mmenavas → created an issue.

Rerolled for Drupal v10.1.2

This patch is based on the MR and it works against version 2.4.0.

Rerolled the last patch against 10.1.2

Rerolled patch #6 to be compatible with latest 2.1.x.

@DamienMcKenna: Thank you for committing the D10 compatibility fixes! Is there a timeline for the next release? Let us know we can help you expedite the next release.

Tested MR #5, and it works well with Group 3.x and Drupal 9.5.x. I recommend merging this MR on a new major version (e.g. 2.x) which will be compatible with Group 2.x and 3.x. The 1.x version can still be maintained to support sites using Group 1.x.

mmenavas → created an issue.

Unfortunately patch #10 does not work on the recently released version 8.x-3.3.

It looks like I'm not the only one who is happy with the patch. What's keeping it from being merged?

It looks like the patch on #2 📌 [PHP8.1] messageDeprecated function: Return type of Drupal\fancy_file_delete\FancyFileDeleteDirectoryOnlyRecursiveFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be Fixed has already been included in the latest release (2.0.8), so this issue could be closed now. However, there's still a bit of room for improvement as we already know what the return type should be for FancyFileDeleteDirectoryOnlyRecursiveFilterIterator::accept(). I created a merge request to add the return type.

mmenavas → made their first commit to this issue’s fork.