Expose setting to enable drag and drop functionality

Created on 1 November 2020, about 4 years ago
Updated 7 December 2023, about 1 year ago

Problem/Motivation

Drag and drop is a nice feature, but not be suitable in all cases.

Proposed resolution

Provide a setting, which will globally enable the dnd feature of jsTree, defaulting to enabled.

✨ Feature request
Status

RTBC

Version

2.1

Component

Code

Created by

πŸ‡¨πŸ‡­Switzerland ytsurk Switzerland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States mmenavas

    Rerolled patch #6 to be compatible with latest 2.1.x.

  • Issue was unassigned.
  • Status changed to RTBC over 1 year ago
  • πŸ‡¨πŸ‡­Switzerland ytsurk Switzerland

    Sorry for having this so long silently assigned to me, doing nothing, but here we go.

    I added the update hook for the config schema change.
    Also renamed stuff a bit and added the config options to a separate fieldset.

  • Status changed to Needs review over 1 year ago
  • πŸ‡¨πŸ‡­Switzerland ytsurk Switzerland

    Sorry - review welcome, especially the update hook (meaning running it on another -dev instance then mine).

  • Status changed to RTBC about 1 year ago
  • πŸ‡ͺπŸ‡ͺEstonia rang501 Viljandi

    I looked at it and found out that the configuration form is not saving the checkbox value. I did find the problem and fixed it.
    Another thing - the bold text about the manual cache rebuild - it was not necessary and I did remove it. I think that any manual cache rebuild is only for cache debugging. This is something that the users shouldn't do at all. We should add correct cache tags or call specific cache rebuild functions during the settings save. At the moment I do not see there is any need for it.

    Overall, it seems to work just fine. I do agree that the option should turn off the dnd functionality completely (both folders and media).

Production build 0.71.5 2024