- Issue created by @nicxvan
- First commit to issue fork.
- Merge request !11450Issue #3488681: Fix defgroup open and close that were separated during Hook conversion → (Open) created by apaderno
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States mradcliffe USA
I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because there is a clearly defined task for resolution. The issue summary could use an update as well.
There were some test failures in the merge request, but I think those are false positives.
- 🇺🇸United States jazzsequence Salt Lake City
I am looking at this issue at DrupalCon Atlanta. I am working with @heilop
- 🇺🇸United States jazzsequence Salt Lake City
Reviewed the patch and confirmed that the def groups were opened and closed appropriately and the orphaned opens and closes were removed.
- Merge request !11653Issue #3488681: Fix defgroup open and close that were separated during Hook conversion → (Open) created by jazzsequence
- 🇵🇪Peru heilop
As @jazzsequence mentioned, the MR request shows that the
defgroupare looking good now.After the new MR has been opened to re-run the tests, we can now confirm that the test passed. Also, the tests were run locally and passed as well.
- 🇺🇸United States mradcliffe USA
It looks like the issue summary has been updated. When updating the issue summary, we want to remember to remove the tag as well.
It would be nice to get another person to do a code review.
- 🇺🇸United States mmenavas
I verified that the functions grouped by @defgroup and @addtogroup are correctly placed and no missing opening and closing doxygen exist.
- 🇨🇷Costa Rica estebanvalerio.h
Just took a look to the MR at https://git.drupalcode.org/project/drupal/-/merge_requests/11653 and it looks good to me
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.