Error message when a user is trying to update all results in all pages does not describe the problem well

Open on Drupal.org →

Created on 6 December 2023, 12 months ago

Updated 26 January 2024, 10 months ago

Problem/Motivation

First of all, thank you so much for creating this module! I am able to update the moderation state of multiple nodes as long as I select the nodes I want update; however, when I choose the option to update all views results, I get the error below which isn't very helpful.

The view does not support passing entities correctly.

Steps to reproduce

- Create a view page of moderated nodes, select table format, add VBO field, add title field, and check the "Transition content to a new workflow state" option.
- Check any box from one of the views results, and check the option to "Select / Deselect" all results from the view.
- Click on "Apply to selected items".
- The next string will show you the error message mentioned above.

Proposed resolution

On VboWorkflowTransition::buildConfigurationForm(), check if the number of selected items is equal to the number of results. This will tell us if a user wants to update all of the views results or just a subset. If a user wants to update all of the results and that functionality is not available, then we can show "Selecting all results in all pages is currently not supported" or "Selecting all results is not supported due to potential performance issues" or something like that.

Remaining tasks

- Update error message when user selects all results in all pages.

User interface changes

- Change in error message when all results are selected.

API changes

None.

Data model changes

None.

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States mmenavas

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!1Error message when a user is trying to update all results in all pages does not describe the problem well
Merged
🇺🇸United States mattsqd
updated 10 months ago

Comments & Activities

Issue created by @mmenavas
First commit to issue fork.
Merge request !1Issue #3406607 by mmenavas: Added support for VBO on 'all pages' and added... → (Merged) created by mattsqd
Status changed to Needs review 11 months ago9:23pm 11 January 2024
Comment 11 months ago →
🇺🇸United States mattsqd
Hi @mmenavas! Thank you for your issue report. I've created a PR that I believe will fix this issue for you.

I went ahead and went the route of allowing it to work on 'all pages' rather than warning them not to use it on all pages.

Perhaps in the future a configuration setting can be added to disallow running VBO on all result sets if it allows editors to kill the site.
Comment 10 months ago →
🇺🇸United States mmenavas
Hi @mattsqd! Thank you for making a PR! I tested your code on one of my Drupal 10 sites, and it works as expected. I was able to change the moderation state for all of my view results. I also tested updating the moderation state for a few items I selected, and that also worked well.

Comment 10 months ago →

3a57ff7f committed on 1.0.x

Issue #3406607 by mmenavas: Added support for VBO on 'all pages' and...

Status changed to Fixed 10 months ago7:27pm 12 January 2024
Comment 10 months ago →
🇺🇸United States mattsqd
Comment 10 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024