- First commit to issue fork.
- @mmenavas opened merge request.
- πΊπΈUnited States mmenavas
It looks like the patch on #2 π [PHP8.1] messageDeprecated function: Return type of Drupal\fancy_file_delete\FancyFileDeleteDirectoryOnlyRecursiveFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be Fixed has already been included in the latest release (2.0.8), so this issue could be closed now. However, there's still a bit of room for improvement as we already know what the return type should be for
FancyFileDeleteDirectoryOnlyRecursiveFilterIterator::accept()
. I created a merge request to add the return type. - Status changed to Fixed
over 1 year ago 7:38pm 25 August 2023 - π¨π¦Canada joseph.olstad
next time please use the commit message from the issue queue (seen below)
example:
git commit -m 'Issue #3280336 by idebr: [PHP8.1] messageDeprecated function: Return type should be compatible with bool, or the #[\ReturnTypeWillChange] attribute should be' --author="Ide Braakman <17730-idebr@users.noreply.drupalcode.org>"
- πΊπΈUnited States mmenavas
Thank you for merging the MR and for pointing out the correct way to commit code. I will follow that from now on so everyone involved in the issue can get credit.
- π¨π¦Canada joseph.olstad
@mmenevas, thanks for the work on this, great to see you noticed my suggestion lol
Automatically closed - issue fixed for 2 weeks with no activity.