- Issue created by @idebr
- π³π±Netherlands idebr
The merge request applies gitlab CI defaults for phpcs
- π¬π§United Kingdom alexpott πͺπΊπ
I'm not convinced we should be using drupal/coder's standards out of the box. Using core's standards mean we only ever adopt rules that actually work for the whole of core. Unfortunately the shipped Drupal standards contain things like the array declaration long line standard which makes code worse and less readable. #3185082-12: Drupal.Arrays.Array.LongLineDeclaration make me write less readable code β kind of lays this all out. But the whole line length limit stuff as shown by the changes here to SettingsForm makes for worse code.
- π³π±Netherlands idebr
Gitlab CI will pick up a custom phpcs configuration, as do IDEs like PHPStorm. Is Drupal.Arrays.Array.LongLineDeclaration the only rule that should not be enforced?
See webform for reference: https://git.drupalcode.org/project/webform/-/blob/6.3.x/phpcs.xml?ref_ty...
- π¬π§United Kingdom alexpott πͺπΊπ
Yep I am aware of that, I just like that core's rules get worked on and that core applies them so I know they are good. Also I find core's ruleset very easy to run locally...
composer run phpcs --modules/content_lock
- π³π±Netherlands idebr
The merge request now include a custom Content Lock phpcs ruleset that excludes Drupal.Arrays.Array.LongLineDeclaration
Changes for Drupal.Arrays.Array.LongLineDeclaration were reverted.
-
alexpott β
committed 5120894c on 3.x authored by
idebr β
Issue #3529824 by idebr, alexpott: Formalize phpcs ruleset
-
alexpott β
committed 5120894c on 3.x authored by
idebr β
Automatically closed - issue fixed for 2 weeks with no activity.