- Issue created by @guiu.rocafort.ferrer
- Status changed to Needs review
4 months ago 1:37pm 16 February 2024 - 🇪🇸Spain guiu.rocafort.ferrer Barcelona
Changing issue priority to Major as per issue priorities →
I am working on issue 2961459 from country_path module ( https://www.drupal.org/project/country_path/issues/2961459 🐛 Country path not managed in domain navigation block Needs review ).
In the issue, the domain navigation block is not adding the correct country path to the urls. The fix to this involves overriding the setUrl and setPath methods for the Domain entity. The setUrl requires to get the active domain country path, to be able to remove it from the current request and append the target url domain country path. This causes an infinite loop, because calling getActiveDomain loads the domain entity, and since the domain_entity_load calls setUrl for the domain, which in turn, loads the active domain entity again, and calls setUrl, and so on.
Since the getUrl and getPath already manage if the value have been generated or not, i believe there is no point on forcing the setUrl and setPath methods on load, and can be removed safely.
Needs review
2.0
Code
Changing issue priority to Major as per issue priorities →