Country path not managed in domain navigation block

guiu.rocafort.ferrer → made their first commit to this issue’s fork.

I applied patch #3, and found the fatal error is caused by an infinite loop.

The setUrl calls getActiveDomain(), which loads the domain entity for the active domain. There was a domain_entity_load hook in the main domain, which calls the setUrl method for the loaded domain, thus creating the loop.

The getUrl() and getPath() methods already check if the value is set, and if not, they call setUrl and setPath, so i am quite sure removing this load hook in the main domain module is safe to do. I will create a follow up issue there.

Until this gets solved in the domain module, i added a hacky solution to stop the infinite loop from happening. In the setUrl i am checking if the function is being called from the domain_entity_load method, and in that case, it does nothing and just returns.

Setting the issue as needs review, so we can merge the branch and solve the issue.

Changing issue Priority to Major as per issue priorities →

Updated patch against lates 8.x-1.x branch.

getActiveDomain shouldn't be looping indefinitely anymore on 2.0.x dev branch. Could you give it a try?

guiu.rocafort.ferrer → changed the visibility of the branch 2961459-country-path-not to hidden.

Hidden one of the branches since the country-path-not-setHostname-handling is more up to date with the latest changes.

I think we should leave the workaround for the domain module infinite loop at least until there is a release including that fix, then we can change the minimum version requirements for the domain module to make sure it has at least the released version with the fix.

I have been testing the branch and seems to work ok, but i think we should write some tests for this.

guiu.rocafort.ferrer → changed the visibility of the branch 2961459-country-path-not to active.

Doing a few tests around i realised that setting the country path in the hostname does not make a lot of sense conceptually, so i went back to the first branch that used that approach.

I also realised that a method to get the request path without the active domain path was needed, because if not, the links for the other domains would also contain the active domain country path, so i created a new method to get the active domain country path.

I also added a functional test that checks the navigation links. Setting as needs review.