[pp-1] Add Dependency injection to Hook classes

Created on 20 January 2025, 7 months ago

Problem/Motivation

Postponed on πŸ“Œ Convert to OOP Hooks Active

Once that is in we can address dependency injection for Hook classes.
This will likely need to be a meta issue since there are a bunch of classes.

Steps to reproduce

Remove these exclusions:

    <exclude name="DrupalPractice.Objects.GlobalDrupal.GlobalDrupal"/>
    <exclude name="DrupalPractice.Objects.GlobalClass.GlobalClass"/>

Run code sniffing

Proposed resolution

Add dependency injection for all of the hook classes that have \Drupal::service calls.

Remaining tasks

Assess what needs updating.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

πŸ“Œ Task
Status

Postponed

Version

6.3

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States nicxvan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @nicxvan
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan
  • Pipeline finished with Canceled
    3 months ago
    Total: 151s
    #507094
  • Pipeline finished with Failed
    3 months ago
    Total: 543s
    #507095
  • Pipeline finished with Failed
    3 months ago
    Total: 404s
    #507113
  • Pipeline finished with Failed
    3 months ago
    Total: 663s
    #507120
  • Pipeline finished with Failed
    3 months ago
    Total: 945s
    #507129
  • Pipeline finished with Skipped
    3 months ago
    #512779
  • Status changed to Needs work 13 days ago
  • πŸ‡³πŸ‡±Netherlands idebr

    πŸ“Œ Convert to OOP Hooks Active was committed.

  • Pipeline finished with Failed
    12 days ago
    Total: 719s
    #571598
  • Pipeline finished with Failed
    12 days ago
    Total: 680s
    #571603
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Thank you for reminding me! I need to finish this, but I just did a bunch more.

  • Pipeline finished with Failed
    12 days ago
    Total: 922s
    #571613
  • Pipeline finished with Failed
    12 days ago
    Total: 543s
    #572218
  • Pipeline finished with Failed
    12 days ago
    Total: 530s
    #572221
  • Pipeline finished with Failed
    12 days ago
    Total: 717s
    #572228
  • Pipeline finished with Failed
    12 days ago
    Total: 775s
    #572245
  • Pipeline finished with Failed
    12 days ago
    Total: 620s
    #572263
  • Pipeline finished with Failed
    12 days ago
    Total: 572s
    #572292
  • Pipeline finished with Failed
    12 days ago
    #572380
  • Pipeline finished with Failed
    12 days ago
    #572382
  • Pipeline finished with Running
    12 days ago
    #572410
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    All failures are related to unrelated issues right now except one.

    Does accessCheck need to be TRUE or FALSE in:
    $entity_ids = $this->entityTypeManager->getStorage('webform_access_group')->getQuery()->condition('type', $entity->getTargetBundle())->execute();

    For the WebformAccessHooks function public function fieldConfigDelete(EntityInterface $entity) {

    Other than that this is ready for review!

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan
Production build 0.71.5 2024