Release lock when browsing away from locked form

I attached the patch version of the current merge request for those working with composer patches.

The last submitted patch, 35: 3160781-35.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

It's better not to post separate patches when using merge requests for the actual changes. It makes it confusing, as people often submit new patches rather than putting later changes into the MR. Just link to the MR patch file, which people can download.

https://git.drupalcode.org/project/content_lock/-/merge_requests/12.patch

But don't reference that merge request URL directly in your composer.json file. Its contents can change at any time, potentially silently breaking your website after new composer installs. Just keep your patch files locally, together with the rest of your website code.

Like the idea but feels like something that should be a form setting or another submodule like timeout is? thoughts.

It should probably be configurable with a setting. However, for content editors who have no idea about Drupal or its functionality, who just manage their content, they might have no idea what "Break lock" means, or they might forget if they do know. I think it's a good feature to add.

But it might not be a setting that all sites want.

Sure, anyone could turn off the setting.

I agree @solideogloria, I have been using this patch for about 2 years now on a website where I'm an editor, and in my opinion it's a very valuable feature. It would be good to get this in the module at some point. I couldn't imagine always having to unlock the form manually.

I've rebased MR!12, should probably be tested again.

There is a test failure. Is that related?

Also, I'm not sure if this fix is working at all. I have the latest changes applied to a site, I edit a node (locking it), and then I either click "view" to leave the editing screen or close the tab, but the content is still locked.

I can't seem to be able to apply the patch via composer to test.

You have to be using the dev version of the module. It doesn't apply to the latest release.

I couldn't applied #35 patch for dev or 2.4 version. Re-rolled patch for 2.4 version.