- last update
almost 2 years ago Patch Failed to Apply There appears to be an issue with patches #7 and #11 where they add additional lock messages when editing published content.
When using the paragraph system, clicking edit makes a POST call to Drupal which triggers the form alter logic. This means large content pieces can have many lock messages appear which can be very distracting. I have added an image demonstrating this.
It is possible to prevent these messages by first checking how the form alter request is being made. If it's a POST request, then it's likely a paragraph being edited and no message needs to be displayed. However, if it's a GET request, then the user is likely navigating to the page from either the content preview or the content listing page and the message should be displayed.
- Status changed to Postponed: needs info
over 1 year ago 5:42pm 21 March 2024 - πΊπΈUnited States smustgrave
I tried replicating on the latest 2.x branch but wasn't able to. Is this still an issue?
- Status changed to Needs work
over 1 year ago 2:53pm 26 March 2024 - πΊπΈUnited States smustgrave
Wasn't able to replicate but think the message that the content is locked should still be there.
- Status changed to Needs review
over 1 year ago 6:10pm 27 March 2024 - πͺπΈSpain enchufe Spain
Fixed bug that caused fatal error from
3.0.0-alpha2
reroll π Previewing appears to unlock node RTBC on locked entity deletion. - π¦πΊAustralia VladimirAus Brisbane, Australia
vladimiraus β changed the visibility of the branch 3.x to hidden.
- π¦πΊAustralia VladimirAus Brisbane, Australia
Create a branch for v3.
- π¬π§United Kingdom alexpott πͺπΊπ
alexpott β changed the visibility of the branch 2949202-previewing-appears-to to hidden.
- π¬π§United Kingdom alexpott πͺπΊπ
Rebase the d11 branch on the latest 3.x - I don't think the fix is currently working because the d11 mr still leaves the user input check in.
- π¬π§United Kingdom alexpott πͺπΊπ
I feel this is a major bug because you're left no knowing the lock state of the entity.
- π©πͺGermany chr.fritsch π©πͺπͺπΊπ
alexpott β credited chr.fritsch β .
-
alexpott β
committed 74b9b7f6 on 3.x authored by
vladimiraus β
Issue #2949202 by alexpott, smustgrave, vladimiraus, enchufe,...
-
alexpott β
committed 74b9b7f6 on 3.x authored by
vladimiraus β
Automatically closed - issue fixed for 2 weeks with no activity.