Overall it looks nice there are some small issues tho i have encountered. For example the slider height varies based on the next and previous slide.
This patch does apply, and reflects the code and fixing in the MR : 3935b475
remco hoeneveld → made their first commit to this issue’s fork.
Reroll for 10.3 with latest changes applied from issues/3487031 🐛 Performance Degraded after update to twig 3.14.2 Active
Great stuf! can confirm the site i worked on was also fixed by adding `twig/twig": "~v3.14.2"`
Great stuf albert!
Hey Albert agreed! I also found another issue will make a new patch today and merge request so we can fix this for drupal 10.3 and 11.
remco hoeneveld → created an issue.
I Have supplied a patch that updates the validation in the updateLink and updateDefinition as described above, ofcourse it could be cleaner if it would happen in the form processing, but for now this works. FYI my patch is for Drupal 10.3 so i dont know if it will apply for later version like Drupal 11.
Remco Hoeneveld → made their first commit to this issue’s fork.
Aah check thanks for letting us know ill test with latest version, i was indeed working with 1.17 version.
Remco Hoeneveld → created an issue.
Remco Hoeneveld → created an issue.
Remco Hoeneveld → created an issue.
You can expect this in the near future! Will be working to get this up and running in the summer.
Remco Hoeneveld → created an issue.
Alright will make a test case showing the issue and will make a branch going towards 11.x
@cilefen, i have altered the commit and made sure we can run al the tests.
Remco Hoeneveld → created an issue.
Remco Hoeneveld → created an issue.
Remco Hoeneveld → created an issue.
there seems to be a fix within the community by combining the following: (this is for drupal 10.1.*)
->
https://www.drupal.org/project/drupal/issues/2910353#comment-12422438
🐛
Prevent saving config entities when configuration overrides are applied
Needs work
Thread of information about the core issue
-> https://git.drupalcode.org/project/drupal/-/merge_requests/6268.diff (diff i created the core patch from)
If you then patch webform with the attached patch after also patching Drupal core then the Config entities cant be overriden anymore.
Thank you for the response guys! Appreciate it, will make a MR / PR this weekend with the changes needed. Ill also look into automated tests.
With friendly greetings
Remco
Dear Maintainer Team, I proposed a solution in https://www.drupal.org/project/shopify/issues/3414025 🌱 New version of the module Active
Dear Maintainer Team, I proposed a solution in https://www.drupal.org/project/shopify/issues/3414025 🌱 New version of the module Active
Remco Hoeneveld → created an issue.
I do notice that Karl Shea (20 december) already removed the if statement but here is a patch for people who want to run latest version of gin and not have this problem.
Remco Hoeneveld → created an issue.
Remco Hoeneveld → made their first commit to this issue’s fork.
Remco Hoeneveld → made their first commit to this issue’s fork.
@saschaeggi great! Thank you for the fast reply! Great to hear its fixed and you also made it a lot nicer code wise! Great stuff
Thanks for testing @kevinfunk!
I added a merge request!
Here is a fix where i actually fix the chevron that is still wrong in the latest dev.
I was not, now i am using the latest version, ill see still some issues, ill make a new patch based on the latest dev version!
Remco Hoeneveld → created an issue.
Remco Hoeneveld → created an issue.
Remco Hoeneveld → created an issue.