- Issue created by @Remco Hoeneveld
- First commit to issue fork.
- Status changed to Needs review
5 months ago 7:22am 9 July 2024 - Status changed to RTBC
5 months ago 7:55am 9 July 2024 - 🇮🇳India abhiyanshu
The attached patch is working fine, and I am no longer getting the warning of an undefined array.
Moving it to RTBC. Thanks! - Status changed to Needs work
5 months ago 8:26am 9 July 2024 - 🇳🇱Netherlands johnv
Wow, this is an example of fast cooperation.
Alas, the suggested patch/MR only repairs the symptom.
The functionformatTimeSlots(array $office_hours, array $settings, array $field_settings)receives the$settingsarray, which should have passed theOfficeHoursFOrmatterBase::defaultSettings()function, tht fills the required field.
The correct patch should ensure that this happens. - 🇳🇱Netherlands johnv
Oh, and line 511 is not relevant for this issue in the dev version.
I guess, OP uses 1.17 version, not dev version. Please state correct version, then test with current dev version. The error should not appear (at least, I cannot reproduce the error.) - 🇳🇱Netherlands Remco Hoeneveld
Aah check thanks for letting us know ill test with latest version, i was indeed working with 1.17 version.
- Status changed to Postponed: needs info
5 months ago 7:34am 17 July 2024 - 🇳🇱Netherlands johnv
For the same problem, I opened and fixed 🐛 Warning: Undefined array key "all_day_format" in OfficeHoursItemList->formatTimeSlots() (line 531 of \OfficeHoursFormatterTrait.php) Fixed , having forgotten the existence of this issue.
Please check the latest version (1.19 or dev) and close the issue if the problem is solved, or re-open if not.