Local tasks broken because of if statement

Created on 5 January 2024, 12 months ago

Problem/Motivation

In the latest version (8.x-3.0-rc8) of our software, a new 'if' statement was introduced. However, this statement can disrupt the functionality of local tasks when these tasks are lazy-loaded. This issue typically arises during testing on a user account that lacks 'administer webform' permissions. A prime example of this problem is evident in the local tasks for webform. These tasks, which are lazy-loaded, no longer render when the user does not have the permission to administer webform. We suggest that the solution to this problem is to remove the 'if' statement. When the tasks are lazy-loaded, they always return an empty string, making it impossible to verify the validity of the statement.

Steps to Reproduce

To reproduce this issue, install the latest version of gin and navigate to the webform. Check to see if the local tasks are rendered when not logged in with 'administer webform' permissions.

Proposed Resolution

The proposed resolution to this problem is to remove the 'if' statement. We believe it's preferable to render some HTML rather than disrupt the functionality.

Remaining Tasks

The remaining task is to identify a solution to the issue with lazy loading.

User Interface Changes

No changes to the user interface will occur as a result of this fix.

API Changes

No changes to the API will occur as a result of this fix.

Data Model Changes

No changes to the data model will occur as a result of this fix.

🐛 Bug report
Status

Closed: outdated

Component

Code

Created by

🇳🇱Netherlands Remco Hoeneveld

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024