A reverted revision is not listed on the version history

Nice find @idebr, tested locally and the call to createRevision will fix this for Diff. I'm going to work on this today.

I'll also open a follow up to have NodeRevisionRevertForm extend RevisionRevertForm as there's a lot of duplication there.

Test coverage shows the issue is fixed. Contrib tests in 🐛 Fix tests (next minor) Active are fixed as well with this change. Thanks!

We can clean a bit then, left a comment.

I also verified that \Drupal\node\Form\NodeRevisionRevertTranslationForm::prepareRevertedRevision does this correctly.

The redundant lines were removed.

Hi, I’m new to the issue queue ,I setup a fresh Drupal 11.2 site and tried the above mention steps to replicate the bugs,After the revert, a new revision shows up in the list and is marked as the current one, so everything looks normal on my end.Is there another condition that I need to add to see the bug?Let me know and I’ll test again.

I added a screencast on a new Drupal standard installation on 11.2.x with steps to reproduce

@idebr Thanks for checking it out.Please try making some changes while editing the content, then save it. Once saved, try reverting the content to see if the issue reproduces.

Looks good to me.

    // The node should retain the translations from the last default revision.
    // @see \Drupal\Core\Entity\ContentEntityStorageBase::createRevision.
    $this->assertTrue($node->hasTranslation('it'));

This feels like a massive change of expectations. If you revert to a revision before a translation a translation has been created I would not expect translations that were added afterwards to exist. I don't know but this choice seems deliberate.

Are we sure this change is correct?

@alexpott that's exactly what ContentEntityStorageBase::createRevision is documented to do from what I'm reading. Without this fix, reverting a Node to a more recent revision that is not current (i.e clicking Set as current revision) has a really weird outcome and essentially bugs out the revision list (try running the tests without the fix and looking at the HTML output or debugging yourself).