Change cache to use contexts rather than max-age

Created on 23 October 2023, about 1 year ago

Updated 19 December 2023, 11 months ago

Problem/Motivation

We noticed that this module won't cache properly, due to being explicitly set, we would like all our pages to
be cached as much as possible.

Steps to reproduce

Install the module, drupal/cache_review
look at page, and the language switcher will have a Red N, which has cache options matched to auto_placeholder_conditions

Proposed resolution

Change from max-age: 0 to use language contexts

🐛 Bug report

Status

Needs work

Version

2.1

Component

Code

Created by

🇳🇿New Zealand atowl

Live updates comments and jobs are added and updated live.

cache

Comments & Activities

Issue created by @atowl
Comment about 1 year ago →
🇳🇿New Zealand atowl
Status changed to Needs work 11 months ago7:23pm 19 December 2023
Comment 11 months ago →
🇨🇦Canada SKAUGHT
is 'language' the only context you are saying should be cached for? myself, I understand the purpose of a language block Not cacheing at all, as other pages maybe updated (results in url-alais change), published/unpublished.. etc. i suspect language alone is lacking..
-test cases.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024