๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
Account created on 8 May 2012, almost 13 years ago
  • Drupal Senior Developer at FFW Agencyย  โ€ฆ
#

Recent comments

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Here is a patch that adding such parameter.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

kala4ek โ†’ created an issue.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Hm, according to issues descriptions - not.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Reroll of #2 for latest dev version.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Reroll of #2 for latest dev version.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Batch should be used for such update hooks. Because update took large amount of time for sites which have a lot of redirects (for example we have more then 46k).
Or instead of saving the whole entity, just simple sql query is preferable. Because during execution of the update hook site is unavailable (maintenance mode is enabled automatically when updates are executing).

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Fresh patch based on 11MR (but it can be applied to latest 2.3 release). And also safe to use with composer.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Here is simple patch. We just don't need to recheck link if it wasn't changed in redirect.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Faced the same issue, but only for one redirect. We have the same two modules enabled.
Was able to reproduce it locally so going to debug it in nearest days.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

kala4ek โ†’ changed the visibility of the branch project-update-bot-only to hidden.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

kala4ek โ†’ changed the visibility of the branch 3431537-d11-compatibility to hidden.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

kala4ek โ†’ changed the visibility of the branch 3431537-d11_ready to hidden.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Fixed in ๐Ÿ› Uncaught PHP Exception Active

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Looks like locale_form_redirect_edit_form_alter() was already removed during some other ticket and patch from #8 not applied anymore. So here is updated patch.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Will try to reproduce it with clean installation.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Updated patch that works with nested paragraphs too.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Most probably it was solved during ๐Ÿ› Invalid argument exception when changing language of node with menu link to und or zxx Fixed in 10.2.x.
Please recheck and provide a feedback.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

The same as patch from #17, but now with bulk delete support.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Why it's not enough to check by $translation->access('view')?
If user has access to view unpublished page (admin user for example) it make sense also to show a language link.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

- Hiding all the patches except images for further confusion since we are following MR approach now.

It's a wrong approach, patches still needed, at least to be able to use it in ongoing projects with composer.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

kala4ek โ†’ created an issue.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Btw, works perfectly more than half of the year.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Adapted #12 so it can be applied to 1.17 version.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Updated patch to be applicable for 1.11 version.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Hm, but how it will works with entity edit forms? Looks like now trashed entites wouldn't displayed in referency fields anymore and after submitting the form, reference would gone. That means if the admin will restore the trashed node, it wouldn't appears at the place where it was before...

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

We may let drupal automatically remove such "non-existent permissions" during role save.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Unforchanately it doesn't fully related to simple sitemap, because it was breaked at the core level, during ๐Ÿ› Missing url prefix on language neutral content Fixed tiket.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

That issue is breaks the link that must be always neutral, like links insite sitemap.xml (if there are a lot of links the additional sitemaps are generated) and most probalby some more such cases.
Because the code was relied on "not applicable" language, but now the language applied anyway...

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

That issue should be solved much early than module fully get rid from jquery. Because on D10 instances it already cause errors.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

To get a "purge" operation ,you can try to use patch from โœจ Add "Purge" operation link Fixed .

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

You may create your own view. Just set a "deleted" filter and display all other columns/filter that you want.
Ypu even may palce it into /admin/content/trash path.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Simple and working patch for 9.5.x.
Added new separate filters by system path and language.
No test were changed or added, feel free to add, like during last 8 years :)

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Attaching changes from MR as a patch, so it can be safely applied via composer.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Increasing the priority of that ticket, because a lot of code do compare entities in the wrong way now.

Also attached the actual changes from MR as patch, so it can be safely used with composer.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Attaching changes from MR as a patch file, so it can be safely used with composer.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

kala4ek โ†’ created an issue.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Updated patch to be compatible to latest dev version.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Attaching changes from MR as a patch, just to have possibility to safety apply it via composer.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Here is a patch with support for pathauto and translations.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

kala4ek โ†’ created an issue.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Here is a patch that implemented it.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Small patch that add and call "trash_restore_entity" hook.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

kala4ek โ†’ created an issue.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Also need to override default ValidReference constraint.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

kala4ek โ†’ created an issue.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Attaching changes as a patch file, to have possibility use it with composer.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Attaching changes as a patch file, to have possibility use it with composer.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

Checked on latest 3.x-dev - it's already fixed.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk
๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

kala4ek โ†’ created an issue.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

kala4ek โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

kala4ek โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ท๐Ÿ‡บRussia kala4ek ๐Ÿ‡ท๐Ÿ‡บ Novosibirsk

A little bit adjusted patch from #16.
Now it also tries to display the actual field name from nested paragraph.

Production build 0.71.5 2024