Global constants should not be used, move it to a class or interface

Open on Drupal.org →

Created on 7 August 2023, over 1 year ago

Problem/Motivation

PHPCS reports that it is best if the global constants are defined in their own class and accessed as such.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Active

Version

2.0

Component

Code

Created by

🇮🇳India sidharth_soman Bangalore

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @sidharth_soman
Comment over 1 year ago →
🇮🇳India sidharth_soman Bangalore
Status changed to Needs review 5 months ago7:46pm 6 September 2024
Comment 5 months ago →
🇨🇴Colombia yasminOrj
I will test this patch
Status changed to RTBC 4 months ago9:05pm 13 September 2024
Comment 4 months ago →
🇨🇴Colombia yasminOrj
HI
I have tested the patch 3379782-2.patch → and confirmed that it has been successfully applied to the drupal/lang_dropdown module. The refactoring changes included in the patch were correctly integrated and function as expected. No issues were encountered during the application of the patch, and it has been verified that the intended modifications are working properly.

Best Regards.
Assigned to kala4ek
Comment 8 days ago →
🇷🇺Russia kala4ek 🇷🇺 Novosibirsk

Comment 8 days ago →

kala4ek → committed 0ab1b0b5 on 8.x-2.x

Issue #3379782 by sidharth_soman, yasminorj, kala4ek: Global constants...

Comment 8 days ago →
🇷🇺Russia kala4ek 🇷🇺 Novosibirsk

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024