XHProfRequestMatcher::matches() should be compatible with RequestMatcherInterface::matches()

Created on 2 January 2023, almost 2 years ago
Updated 28 June 2024, 5 months ago

Problem/Motivation

We get this error:

PHP Fatal error:  Declaration of Drupal\xhprof\RequestMatcher\XHProfRequestMatcher::matches(Symfony\Component\HttpFoundation\Request $request) must be compatible with Symfony\Component\HttpFoundation\RequestMatcherInterface::matches(Symfony\Component\HttpFoundation\Request $request): bool in /var/www/web/modules/contrib/xhprof/src/RequestMatcher/XHProfRequestMatcher.php on line 37

Steps to reproduce

Install xhprof 8.x-1.0-beta6 on Drupal 10.0.0 with PHP 8.1.

Proposed resolution

XHProfRequestMatcher::matches() should declare its return type.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇫🇷France prudloff Lille

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024