- Issue created by @alex.bukach
- 🇨🇦Canada joelpittet Vancouver
I was seeing this before applying the MR diff locally, tempted to mark as a bug report, but no idea how this impacts <=10.4. This resolves issues when using 10.5
TypeError: e.icons is undefined
o https://drupal.test/modules/contrib/ckeditor_iframe/js/build/iframeembed...
_createFormView https://drupal.test/modules/contrib/ckeditor_iframe/js/build/iframeembed...
init https://drupal.test/modules/contrib/ckeditor_iframe/js/build/iframeembed...
promise callback*./packages/ckeditor5-core/src/index.ts/init/m/< https://drupal.test/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5-dll.js?v=45.2.0:5
m https://drupal.test/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5...
init https://drupal.test/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5...
initPlugins https://drupal.test/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5...
create https://drupal.test/core/assets/vendor/ckeditor5/editor-classic/editor-c...
create https://drupal.test/core/assets/vendor/ckeditor5/editor-classic/editor-c...
attach https://drupal.test/core/modules/ckeditor5/js/ckeditor5.js?sy686v:373
editorAttach https://drupal.test/core/modules/editor/js/editor.js?v=10.5.0:304
attach https://drupal.test/core/modules/editor/js/editor.js?v=10.5.0:228
attach https://drupal.test/core/modules/editor/js/editor.js?v=10.5.0:211
attachBehaviors https://drupal.test/core/misc/drupal.js?v=10.5.0:166
attachBehaviors https://drupal.test/core/misc/drupal.js?v=10.5.0:162
https://drupal.test/core/misc/drupal.init.js?v=10.5.0:32
listener https://drupal.test/core/misc/drupal.init.js?v=10.5.0:20
domReady https://drupal.test/core/misc/drupal.init.js?v=10.5.0:26
https://drupal.test/core/misc/drupal.init.js?v=10.5.0:31
https://drupal.test/core/misc/drupal.init.js?v=10.5.0:34
ckeditor5.js:467:19Thanks @alex.bukach!
- 🇳🇿New Zealand ericgsmith
Plugin change looks good - but I think this will also need a change to core_version_requirement in the info file to be 10.5 and later for 10 and 11.2 or later for 11
- 🇨🇦Canada man-1982
Had issue after update to drupal 10.5.2
typeError: Cannot read properties of undefined (reading 'check') at new o (iframeembed.js?sysm2q:1:6331) at s._createFormView (iframeembed.js?sysm2q:1:8658) at s.init (iframeembed.js?sysm2q:1:7771)
The patch has solved the issue.
Thank you!