- Issue created by @roshni27
- Status changed to Needs review
over 1 year ago 5:33pm 6 July 2023 - last update
over 1 year ago 3 pass - Status changed to Needs work
9 months ago 7:11am 27 February 2024 - 🇮🇳India Ashutosh Ahirwal India
Hi Provided patch get applied cleanly but still found some error.
Used command with arguments:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/webform_productFILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/webform_product.routing.yml
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------
6 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
13 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
20 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
--------------------------------------------------------------------------------------------------------------------FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/src/WebFormProductFormHelper.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $element_info.
-------------------------------------------------------------------------------------------------------------------------Time: 532ms; Memory: 16MB
-
nagy.balint →
committed 756eb1c1 on 3.1.x
Issue #3372977 by roshni27, nagy.balint, Ashutosh Ahirwal: Fix the...
-
nagy.balint →
committed 756eb1c1 on 3.1.x
- Status changed to Fixed
about 2 months ago 12:17pm 17 September 2024 -
nagy.balint →
committed 8fa9a9d5 on 3.1.x
Issue #3372977 by nagy.balint: Fix the issues reported by phpcs.
-
nagy.balint →
committed 8fa9a9d5 on 3.1.x
- 🇭🇺Hungary nagy.balint
Now it only does not like the api.php, but it should not analyse that anyways.
Automatically closed - issue fixed for 2 weeks with no activity.