Fix the issues reported by phpcs

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/webform_product.routing.yml -------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------- 6 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 13 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 20 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction -------------------------------------------------------------------------------------------------------------------- FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/src/WebFormProductFormHelper.php ------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 27 | WARNING | Unused variable $element_info. ------------------------------------------------------------------------------------------------------------------------- Time: 532ms; Memory: 16MB

Comments & Activities

Issue created by @roshni27
Comment 12 months ago →
🇮🇳India roshni27
Status changed to Needs review 12 months ago5:33pm 6 July 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
3 pass
Comment 12 months ago →
🇮🇳India roshni27
I have fixed all errors ,Please review patch.
Status changed to Needs work 4 months ago7:11am 27 February 2024
Comment 4 months ago →
🇮🇳India Ashutosh Ahirwal India
Hi Provided patch get applied cleanly but still found some error.
Used command with arguments:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/webform_product

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/webform_product.routing.yml
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------
6 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
13 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
20 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
--------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/src/WebFormProductFormHelper.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $element_info.
-------------------------------------------------------------------------------------------------------------------------

Time: 532ms; Memory: 16MB
Comment 4 months ago →
🇮🇳India zkhan.aamir
Issue summary updated.

Fix the issues reported by phpcs

Problem/Motivation

User interface changes

API changes

Data model changes

Comments & Activities