Fix the issues reported by phpcs

Created on 6 July 2023, over 1 year ago
Updated 17 September 2024, about 2 months ago

Problem/Motivation

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/webform_product.routing.yml
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------
6 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
13 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
20 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
--------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/src/WebFormProductFormHelper.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $element_info.
-------------------------------------------------------------------------------------------------------------------------

Time: 532ms; Memory: 16MB

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇮🇳India roshni27

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @roshni27
  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    3 pass
  • 🇮🇳India roshni27

    I have fixed all errors ,Please review patch.

  • Status changed to Needs work 9 months ago
  • 🇮🇳India Ashutosh Ahirwal India

    Hi Provided patch get applied cleanly but still found some error.
    Used command with arguments:-
    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/webform_product

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/webform_product.routing.yml
    --------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------------------------------------------------
    6 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
    13 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
    20 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
    --------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/src/WebFormProductFormHelper.php
    -------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------
    27 | WARNING | Unused variable $element_info.
    -------------------------------------------------------------------------------------------------------------------------

    Time: 532ms; Memory: 16MB

  • 🇮🇳India zkhan.aamir

    Issue summary updated.

  • 🇭🇺Hungary nagy.balint

    Updated patch

    • nagy.balint committed 756eb1c1 on 3.1.x
      Issue #3372977 by roshni27, nagy.balint, Ashutosh Ahirwal: Fix the...
  • Status changed to Fixed about 2 months ago
  • 🇭🇺Hungary nagy.balint

    Now it only does not like the api.php, but it should not analyse that anyways.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024