Issue reported by Drupal coding standards

Created on 26 November 2023, about 1 year ago
Updated 4 March 2024, 10 months ago

Problem/Motivation

Resolved issues reported by Drupal coding standards.

Steps to reproduce

1. Run PHP coding standard to regenerate the report
the report is generated using following command

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml private_taxonomy

FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\private_taxonomy\tests\src\Functional\PrivateTaxonomyViewsTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 19 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
-------------------------------------------------------------------------------------------------------------------------------------------------

Time: 875ms; Memory: 16MB

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs work

Version

2.0

Component

Code

Created by

🇮🇳India adwivedi008

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @adwivedi008
  • Status changed to Needs review about 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    17 pass
  • 🇮🇳India adwivedi008

    Resolved all issues

    The remaining issues after applying the patch are

    
    FILE: private_taxonomy/private_taxonomy.module
    ---------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------------
     234 | WARNING | Unused variable $table.
    ---------------------------------------------------------------------------------------------------------------
    
    FILE: private_taxonomy/tests/src/Functional/PrivateTaxonomyViewsTest.php
    -------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------------------------
     19 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
    -------------------------------------------------------------------------------------------------------------------------------------------------
    Time: 315ms; Memory: 18MB
    
  • Status changed to Needs work 11 months ago
  • 🇮🇳India Ashutosh Ahirwal India

    Confirming the #2 comment and moving to Need work for remaining issue.

  • Assigned to nitin_lama
  • 🇮🇳India nitin_lama India

    Providing updated patch.

  • Status changed to Needs review 11 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 11 months ago
    1 pass, 8 fail
  • Issue was unassigned.
  • 🇮🇳India zkhan.aamir

    Hi,

    Patch #5 applied successfully.

    Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/private_taxonomy (8.x-2.x)
    $ curl https://www.drupal.org/files/issues/2024-02-07/3404201-5.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 18305  100 18305    0     0  27131      0 --:--:-- --:--:-- --:--:-- 27158
    patching file private_taxonomy.module
    patching file private_taxonomy.tokens.inc
    patching file src/Controller/TermAutocompleteController.php
    patching file src/Form/PrivateTaxonomySettingsForm.php
    patching file src/Plugin/Field/FieldFormatter/PrivateTaxonomyFormatterBase.php
    patching file src/Plugin/Field/FieldType/PrivateTaxonomyTermReferenceItem.php
    patching file src/Plugin/Field/FieldWidget/PrivateTaxonomyAutocompleteWidget.php
    patching file tests/src/Functional/PrivateTaxonomyPermissionsTest.php
    patching file tests/src/Functional/PrivateTaxonomySettingsTest.php
    patching file tests/src/Functional/PrivateTaxonomyTestBase.php
    patching file tests/src/Functional/PrivateTaxonomyViewsTest.php
    

    Remaining issue.

    Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules
    $ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml private_taxonomy/
    
    FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\private_taxonomy\tests\src\Functional\PrivateTaxonomyViewsTest.php
    -------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------------------------
     19 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
    -------------------------------------------------------------------------------------------------------------------------------------------------
    
    Time: 875ms; Memory: 16MB
    
  • 🇮🇳India zkhan.aamir

    Issue summary updated.

Production build 0.71.5 2024