- Issue created by @adwivedi008
- Status changed to Needs review
7 months ago 12:20pm 26 November 2023 - last update
7 months ago 17 pass - 🇮🇳India adwivedi008
Resolved all issues
The remaining issues after applying the patch are
FILE: private_taxonomy/private_taxonomy.module --------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------- 234 | WARNING | Unused variable $table. --------------------------------------------------------------------------------------------------------------- FILE: private_taxonomy/tests/src/Functional/PrivateTaxonomyViewsTest.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------- 19 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations. ------------------------------------------------------------------------------------------------------------------------------------------------- Time: 315ms; Memory: 18MB - Status changed to Needs work
5 months ago 7:23am 6 February 2024 - 🇮🇳India Ashutosh Ahirwal India
Confirming the #2 comment and moving to Need work for remaining issue.
- Assigned to nitin_lama
- Status changed to Needs review
5 months ago 7:11am 7 February 2024 - last update
5 months ago 1 pass, 8 fail - Issue was unassigned.
The last submitted patch, 5: 3404201-5.patch, failed testing. View results →
- 🇮🇳India zkhan.aamir
Hi,
Patch #5 applied successfully.
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/private_taxonomy (8.x-2.x) $ curl https://www.drupal.org/files/issues/2024-02-07/3404201-5.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 18305 100 18305 0 0 27131 0 --:--:-- --:--:-- --:--:-- 27158 patching file private_taxonomy.module patching file private_taxonomy.tokens.inc patching file src/Controller/TermAutocompleteController.php patching file src/Form/PrivateTaxonomySettingsForm.php patching file src/Plugin/Field/FieldFormatter/PrivateTaxonomyFormatterBase.php patching file src/Plugin/Field/FieldType/PrivateTaxonomyTermReferenceItem.php patching file src/Plugin/Field/FieldWidget/PrivateTaxonomyAutocompleteWidget.php patching file tests/src/Functional/PrivateTaxonomyPermissionsTest.php patching file tests/src/Functional/PrivateTaxonomySettingsTest.php patching file tests/src/Functional/PrivateTaxonomyTestBase.php patching file tests/src/Functional/PrivateTaxonomyViewsTest.phpRemaining issue.
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules $ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml private_taxonomy/ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\private_taxonomy\tests\src\Functional\PrivateTaxonomyViewsTest.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------- 19 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations. ------------------------------------------------------------------------------------------------------------------------------------------------- Time: 875ms; Memory: 16MB