Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 28 June 2023, over 1 year ago
Updated 29 May 2024, 6 months ago

Problem/Motivation

Remaining issue after applied #2 patch.

Steps to reproduce

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/drupy

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/webpack.config.js
------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------
23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
24 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/README.md
----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 103 characters
5 | WARNING | Line exceeds 80 characters; contains 114 characters
7 | WARNING | Line exceeds 80 characters; contains 147 characters
9 | WARNING | Line exceeds 80 characters; contains 240 characters
12 | WARNING | Line exceeds 80 characters; contains 117 characters
15 | WARNING | Line exceeds 80 characters; contains 170 characters
17 | WARNING | Line exceeds 80 characters; contains 141 characters
19 | WARNING | Line exceeds 80 characters; contains 97 characters
22 | WARNING | Line exceeds 80 characters; contains 89 characters
24 | WARNING | Line exceeds 80 characters; contains 191 characters
----------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/drupy.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/src/js/index.js
----------------------------------------------------------------------------------------------
FOUND 47 ERRORS AFFECTING 46 LINES
----------------------------------------------------------------------------------------------
7 | ERROR | [x] Whitespace found at end of line
10 | ERROR | [x] Whitespace found at end of line
13 | ERROR | [x] Whitespace found at end of line
18 | ERROR | [x] Whitespace found at end of line
21 | ERROR | [x] Whitespace found at end of line
23 | ERROR | [x] Whitespace found at end of line
26 | ERROR | [x] Whitespace found at end of line
29 | ERROR | [x] Whitespace found at end of line
31 | ERROR | [x] Whitespace found at end of line
32 | ERROR | [x] Whitespace found at end of line
33 | ERROR | [x] Whitespace found at end of line
35 | ERROR | [x] Whitespace found at end of line
39 | ERROR | [x] Whitespace found at end of line
42 | ERROR | [x] Whitespace found at end of line
44 | ERROR | [x] Whitespace found at end of line
50 | ERROR | [x] Whitespace found at end of line
52 | ERROR | [x] Whitespace found at end of line
53 | ERROR | [x] Whitespace found at end of line
57 | ERROR | [x] Whitespace found at end of line
60 | ERROR | [x] Whitespace found at end of line
61 | ERROR | [x] Whitespace found at end of line
62 | ERROR | [x] Whitespace found at end of line
63 | ERROR | [x] Whitespace found at end of line
64 | ERROR | [x] Whitespace found at end of line
65 | ERROR | [x] Whitespace found at end of line
72 | ERROR | [x] Whitespace found at end of line
75 | ERROR | [x] Whitespace found at end of line
78 | ERROR | [x] Whitespace found at end of line
79 | ERROR | [x] Whitespace found at end of line
81 | ERROR | [x] Whitespace found at end of line
82 | ERROR | [x] Whitespace found at end of line
85 | ERROR | [x] Whitespace found at end of line
86 | ERROR | [x] Whitespace found at end of line
90 | ERROR | [x] Whitespace found at end of line
93 | ERROR | [x] Whitespace found at end of line
94 | ERROR | [x] Whitespace found at end of line
96 | ERROR | [x] Whitespace found at end of line
97 | ERROR | [x] Whitespace found at end of line
100 | ERROR | [x] Whitespace found at end of line
102 | ERROR | [x] Whitespace found at end of line
103 | ERROR | [x] Whitespace found at end of line
105 | ERROR | [x] Whitespace found at end of line
106 | ERROR | [x] Whitespace found at end of line
107 | ERROR | [x] Whitespace found at end of line
115 | ERROR | [x] Whitespace found at end of line
122 | ERROR | [x] Expected 1 newline at end of file; 0 found
122 | ERROR | [x] Additional whitespace found at end of file
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 47 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/src/js/_menu_toggler.js
------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------
39 | ERROR | [x] Expected 1 space before "-"; 0 found
39 | ERROR | [x] Expected 1 space after "-"; 0 found
72 | ERROR | [x] Expected 1 newline at end of file; 3 found
74 | ERROR | [x] Additional whitespace found at end of file
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------

Time: 236ms; Memory: 12MB

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇮🇳India Prachi6824

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Prachi6824
  • Assigned to Prachi6824
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India Prachi6824

    Hello,

    I have created a patch to solve the errors reported by the phpcs within the .theme file .

    Please review and apply it .

  • Issue was unassigned.
  • Comment 10 months ago →
    🇷🇺Russia zniki.ru
  • Status changed to Needs work 9 months ago
  • Comment 9 months ago →
    🇮🇳India Ashutosh Ahirwal India

    Hi Provided patch in #2 get applied cleanly and resolved issue found in .theme file but still there are so many issue found

    Command used with arguments
    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/drupy

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/webpack.config.js
    ------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 2 LINES
    ------------------------------------------------------------------------------------------------
    23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
    24 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    ------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/README.md
    ----------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
    ----------------------------------------------------------------------------------------
    4 | WARNING | Line exceeds 80 characters; contains 103 characters
    5 | WARNING | Line exceeds 80 characters; contains 114 characters
    7 | WARNING | Line exceeds 80 characters; contains 147 characters
    9 | WARNING | Line exceeds 80 characters; contains 240 characters
    12 | WARNING | Line exceeds 80 characters; contains 117 characters
    15 | WARNING | Line exceeds 80 characters; contains 170 characters
    17 | WARNING | Line exceeds 80 characters; contains 141 characters
    19 | WARNING | Line exceeds 80 characters; contains 97 characters
    22 | WARNING | Line exceeds 80 characters; contains 89 characters
    24 | WARNING | Line exceeds 80 characters; contains 191 characters
    ----------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/drupy.info.yml
    -----------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------
    1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
    -----------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/src/js/index.js
    ----------------------------------------------------------------------------------------------
    FOUND 47 ERRORS AFFECTING 46 LINES
    ----------------------------------------------------------------------------------------------
    7 | ERROR | [x] Whitespace found at end of line
    10 | ERROR | [x] Whitespace found at end of line
    13 | ERROR | [x] Whitespace found at end of line
    18 | ERROR | [x] Whitespace found at end of line
    21 | ERROR | [x] Whitespace found at end of line
    23 | ERROR | [x] Whitespace found at end of line
    26 | ERROR | [x] Whitespace found at end of line
    29 | ERROR | [x] Whitespace found at end of line
    31 | ERROR | [x] Whitespace found at end of line
    32 | ERROR | [x] Whitespace found at end of line
    33 | ERROR | [x] Whitespace found at end of line
    35 | ERROR | [x] Whitespace found at end of line
    39 | ERROR | [x] Whitespace found at end of line
    42 | ERROR | [x] Whitespace found at end of line
    44 | ERROR | [x] Whitespace found at end of line
    50 | ERROR | [x] Whitespace found at end of line
    52 | ERROR | [x] Whitespace found at end of line
    53 | ERROR | [x] Whitespace found at end of line
    57 | ERROR | [x] Whitespace found at end of line
    60 | ERROR | [x] Whitespace found at end of line
    61 | ERROR | [x] Whitespace found at end of line
    62 | ERROR | [x] Whitespace found at end of line
    63 | ERROR | [x] Whitespace found at end of line
    64 | ERROR | [x] Whitespace found at end of line
    65 | ERROR | [x] Whitespace found at end of line
    72 | ERROR | [x] Whitespace found at end of line
    75 | ERROR | [x] Whitespace found at end of line
    78 | ERROR | [x] Whitespace found at end of line
    79 | ERROR | [x] Whitespace found at end of line
    81 | ERROR | [x] Whitespace found at end of line
    82 | ERROR | [x] Whitespace found at end of line
    85 | ERROR | [x] Whitespace found at end of line
    86 | ERROR | [x] Whitespace found at end of line
    90 | ERROR | [x] Whitespace found at end of line
    93 | ERROR | [x] Whitespace found at end of line
    94 | ERROR | [x] Whitespace found at end of line
    96 | ERROR | [x] Whitespace found at end of line
    97 | ERROR | [x] Whitespace found at end of line
    100 | ERROR | [x] Whitespace found at end of line
    102 | ERROR | [x] Whitespace found at end of line
    103 | ERROR | [x] Whitespace found at end of line
    105 | ERROR | [x] Whitespace found at end of line
    106 | ERROR | [x] Whitespace found at end of line
    107 | ERROR | [x] Whitespace found at end of line
    115 | ERROR | [x] Whitespace found at end of line
    122 | ERROR | [x] Expected 1 newline at end of file; 0 found
    122 | ERROR | [x] Additional whitespace found at end of file
    ----------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 47 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/src/js/_menu_toggler.js
    ------------------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AFFECTING 3 LINES
    ------------------------------------------------------------------------------------------------------
    39 | ERROR | [x] Expected 1 space before "-"; 0 found
    39 | ERROR | [x] Expected 1 space after "-"; 0 found
    72 | ERROR | [x] Expected 1 newline at end of file; 3 found
    74 | ERROR | [x] Additional whitespace found at end of file
    ------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------

    Time: 236ms; Memory: 12MB

  • Comment 9 months ago →
    🇮🇳India Anjali Mehta

    Anjali Mehta → made their first commit to this issue’s fork.

  • Merge request !1Resolve #3370870 "Fix the issues" → (Open) created by Anjali Mehta
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    🇮🇳India Anjali Mehta
  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    a.aaronjake

    Hi @anjalimehta1999,

    I applied the MR !1, it applied unsuccessfully.

    drupy git:(main) ✗ curl https://git.drupalcode.org/project/drupy/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7380    0  7380    0     0  14512      0 --:--:-- --:--:-- --:--:-- 14939
patching file README.md
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file README.md.rej
patching file drupy.info.yml
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file drupy.info.yml.rej
patching file drupy.theme

    Kindly check.

    Thanks,
    Jake

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024