- Issue created by @Harpreet_singh_saluja
- Status changed to Needs review
8 months ago 2:53pm 12 March 2024 - ๐ฎ๐ณIndia Ashutosh Ahirwal India
Ashutosh Ahirwal โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia Ashutosh Ahirwal India
Hi, I have reviewed the #3 and also providing MR with fixes.
Please review it. Hi,
I applied the patch and the MR, it fixed the reported issue however is also resulted to these issues that are reported by phpcs.
FILE: ...site/drupal-orgissue/web/modules/contrib/etherpad_api/etherpad_api.install -------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 16 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, | | question marks, colons, or closing parentheses 22 | ERROR | [x] Expected newline after closing brace 27 | WARNING | [x] A comma should follow the last multiline array item. Found: | | ) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 230ms; Memory: 10MB
Thank you.
Hi,
I applied the patch and the MR, it fixed the reported issue however is also resulted to these issues that are reported by phpcs.
FILE: ...site/drupal-orgissue/web/modules/contrib/etherpad_api/etherpad_api.install -------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 16 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, | | question marks, colons, or closing parentheses 22 | ERROR | [x] Expected newline after closing brace 27 | WARNING | [x] A comma should follow the last multiline array item. Found: | | ) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 230ms; Memory: 10MB
Kindly review.
Thank you.Hi,
Reviewed this yesterday and noticed remaining coding standards issue can be fixed immediately, so I created a patch.
Kindly review.
Thank you.