- Issue created by @hamid.ali
- Assigned to sourojeetpaul
- Merge request !9Issue #3432299: Twitter logo needs to be changed to the X. → (Open) created by sourojeetpaul
- Issue was unassigned.
- Status changed to Needs review
9 months ago 8:34am 28 March 2024 Hello @Hamid.ali,
I tried to reproduce the issue by installing the theme and setting that as default theme of the site, but I found that there's no such social icons section present in the theme intrinsically. I think the screenshot which you attached along the issue is from the demo site of the theme, where the social icons are present in a block "Connect with Us". Also as there are no such block available readily, I think that this block on the demo site is a custom block, which uses fontawesome icons for the icons.
In that case, I tried to replicate the custom block on my own, and observed that the issue is arising due to an older version of fontawesome CDN referenced in the libraries.yml. To mitigate that issue, I've changed the CDN reference to the latest version where the x-twitter logo is available and also raised an MR for the same. Pls have a look:
https://git.drupalcode.org/project/showcase_lite/-/merge_requests/9After making these changes the social icons are showing properly with the updated twitter logo on my block, like this:
- Status changed to Needs work
8 months ago 12:12pm 22 April 2024 - 🇮🇳India Nupur Badola
No section is present for social share icons. Please review.
- Status changed to Needs review
8 months ago 12:18pm 22 April 2024 @Nupur Badola, I've mentioned the same on my last comment #5 🐛 Twitter logo needs to be changed to the X Needs review
The social icons section was made by placing a custom block. Please go through my findings once again!- 🇮🇳India hamid.ali
@sourojeetpaul i replicated the demo site design with the custom block for the social icons. My main aim was to showcase the twitter icon has to be updated which is as u mentioned by updating the lib version
@Hamid.ali, Can you please confirm whether the issue gets resolved my the patch provide by me here!
MR !9- Status changed to RTBC
8 months ago 1:09pm 22 April 2024 - 🇮🇳India Ashutosh Ahirwal India
I have reviewed MR9 and if we use then this will resolve this issue
I have created my own custom block from demo site.
moving to RTBC