Always show slideshow when checkbox is enable/disable.

Created on 8 June 2022, about 2 years ago
Updated 28 July 2023, 11 months ago

Problem/Motivation

Always show slideshow when checkbox is enable/disable.

Steps to reproduce

1) Install "Danland" and set as default.
2) Go to Appearance > settings > Danland.
3) Check front page Slideshow checkbox.
4) Refresh page and check front Slideshow.

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

🇮🇳India Harsh panchal

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue was unassigned.
  • 🇮🇳India Jay Jangid

    Hey @Harsh panchal
    I am just Installed the theme and then Go to Appearance > settings > Danland.
    & Click the Slideshow checkbox. Now slideshow seem working fine in both condition when checkbox is enable or disable.
    Attaching a screenshot for reference.
    Thank you.

  • Status changed to RTBC about 1 year ago
  • Verified the #2 patch on 9.5.8, checkbox functions are working fine now. RTBC++.

  • Status changed to Needs work 11 months ago
  • 🇵🇹Portugal jcnventura

    This should be:

    {% if slideshow_display and page.slideshow %}

  • Status changed to Needs review 11 months ago
  • Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7
    last update 11 months ago
    Waiting for branch to pass
  • 🇮🇳India Dheeraj Jhamtani

    Hi @jcnventura and @Harsh panchal, I have checked the patch and jcnventura solution but both are not solving the issue the patch is just stopping the images to render. When i install the theme there is no preface and highlighted regions which in showing on the page.html.twig. I have created a new patch please review.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 7.4 & MySQL 5.7
    last update 11 months ago
    Composer require failure
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7 updated deps
    last update 11 months ago
    Composer require failure
Production build 0.69.0 2024