🇮🇳India @realsp

realsp → created an issue.

Hi @TonyPa, The Merged MR had few remaining coding standards errors related to dependency injection, I've fixed those in the latest MR-2, Please review the MR.
Thank you.

I've created MR to fix the coding standards issues, Please review the MR.
Thank you.

realsp → created an issue. See original summary → .

realsp → created an issue.

Phpcbf is failing to make changes in these files (css & pcss). In this case, css & pcss files 'phpcs issues' will be repeated once the new code is added, since, Postcss is used for theme development.
Earlier, while resolving 'phpcs issues' in other contributed modules, css & js files changes were reverted, need confirmation on this part.

As per the Drupal coding standards → , control structure conditions may exceed 80 characters, if they are simple to read and understand.
Hence, The following phpcs issue can be ignored:

FILE: /home/contribution/drupal/web/themes/contrib/january_theme/january.theme
----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------
  23 | WARNING | Line exceeds 80 characters; contains 87 characters
 352 | WARNING | Line exceeds 80 characters; contains 104 characters
----------------------------------------------------------------------------------------

These are remaining phpcs issues:

FILE: /home/contribution/drupal/web/themes/contrib/january_theme-3364794/january.theme
---------------------------------------------------------------------------------------------------------------------------
FOUND 47 ERRORS AND 5 WARNINGS AFFECTING 38 LINES
---------------------------------------------------------------------------------------------------------------------------
   9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Html.
  14 | WARNING | [x] Unused use statement
  23 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
  47 | ERROR   | [x] Expected 1 blank line after function; 2 found
  53 | ERROR   | [x] Doc comment long description must start with a capital letter
  54 | ERROR   | [x] There must be no blank lines after the function comment
  57 | ERROR   | [x] Opening brace should be on the same line as the declaration
  58 | ERROR   | [x] Expected 1 space before "="; 0 found
  58 | ERROR   | [x] Expected 1 space after "="; 0 found
  61 | ERROR   | [x] Missing function doc comment
  62 | ERROR   | [x] Opening brace should be on the same line as the declaration
  63 | ERROR   | [x] Expected 1 space before "="; 0 found
  63 | ERROR   | [x] Expected 1 space after "="; 0 found
  69 | ERROR   | [x] Doc comment long description must start with a capital letter
  69 | ERROR   | [x] Doc comment long description must end with a full stop
  70 | ERROR   | [x] There must be no blank lines after the function comment
  73 | ERROR   | [x] Opening brace should be on the same line as the declaration
  74 | ERROR   | [x] Expected 1 space before "="; 0 found
  74 | ERROR   | [x] Expected 1 space after "="; 0 found
  74 | ERROR   | [x] Concat operator must be surrounded by a single space
  74 | ERROR   | [x] Concat operator must be surrounded by a single space
  74 | ERROR   | [x] Concat operator must be surrounded by a single space
 118 | ERROR   | [x] Inline comments must start with a capital letter
 178 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 178 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 180 | ERROR   | [x] Expected 1 space before "="; 0 found
 180 | ERROR   | [x] Expected 1 space after "="; 0 found
 181 | ERROR   | [x] Closing brace indented incorrectly; expected 0 spaces, found 2
 270 | ERROR   | [ ] String concat is not required here; use a single string instead
 353 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
 527 | ERROR   | [x] Expected 1 blank line after function; 3 found
 530 | ERROR   | [ ] More than 2 empty lines are not allowed
 533 | ERROR   | [x] There must be no blank lines after the function comment
 669 | ERROR   | [x] Concat operator must be surrounded by a single space
 672 | ERROR   | [ ] Missing short description in doc comment
 673 | ERROR   | [ ] Missing parameter comment
 673 | ERROR   | [ ] Missing parameter type
 674 | ERROR   | [ ] Missing parameter comment
 677 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
 677 | ERROR   | [x] Expected 1 space after closing parenthesis; found 0
 678 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 682 | ERROR   | [ ] Missing short description in doc comment
 683 | ERROR   | [ ] Missing parameter comment
 683 | ERROR   | [ ] Missing parameter type
 684 | ERROR   | [ ] Missing parameter comment
 704 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 717 | WARNING | [x] A comma should follow the last multiline array item. Found: field
 725 | ERROR   | [x] There should be no white space after an opening "("
 725 | ERROR   | [x] There should be no white space before a closing ")"
 731 | ERROR   | [x] Expected 1 space before "="; 0 found
 731 | ERROR   | [x] Expected 1 space after "="; 0 found
 733 | ERROR   | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 40 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/themes/contrib/january_theme-3364794/theme-settings.php
------------------------------------------------------------------------------------------------
FOUND 21 ERRORS AFFECTING 19 LINES
------------------------------------------------------------------------------------------------
  8 | ERROR | [x] There must be exactly one blank line after the file comment
  8 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found
 13 | ERROR | [x] There must be no blank lines after the function comment
 15 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 27 | ERROR | [x] Whitespace found at end of line
 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 34 | ERROR | [x] Whitespace found at end of line
 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 41 | ERROR | [x] Whitespace found at end of line
 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 82 | ERROR | [x] Expected 1 newline at end of file; 0 found
 82 | ERROR | [x] A closing tag is not permitted at the end of a PHP file
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 21 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/themes/contrib/january_theme-3364794/config/install/january.settings.yml
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 21 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------

I'll create MR to fix the phpcs issues.

I've fixed the remaining phpcs issues in MR, Please review the MR.
Thank you.

I'll update the MR to fix the remaining phpcs issues.

Found the following phpcs issues in MR #2,

FILE: /home/contribution/drupal/web/modules/contrib/phpmail_alter/src/Service/PhpMail.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/phpmail_alter/src/Service/DebugService.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
  7 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Extension\ModuleHandlerInterface.
 95 | WARNING | [ ] The use of function dsm() is discouraged
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------

The MR #2, fixes the reported phpcs issues.
Thank you.

I've fixed the remaining phpcs issues in the MR, Please review the MR.
Thank you.

Found following phpcs issues in MR #2,

FILE: /home/contribution/drupal/web/modules/contrib/username_validation/username_validation.routing.yml
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/username_validation/username_validation.links.menu.yml
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/username_validation/username_validation.module
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AND 4 WARNINGS AFFECTING 15 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] Missing file doc comment
   9 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar()
     |         |     for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
  23 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar()
     |         |     for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
  30 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
  55 | ERROR   | [ ] All functions defined in a module file must be prefixed with the module's name, found "_get_username_from_db" but expected
     |         |     "username_validation__get_username_from_db"
  69 | ERROR   | [ ] Missing parameter comment
  70 | ERROR   | [ ] Missing parameter comment
  72 | ERROR   | [ ] Description for the @return value is missing
  82 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 114 | ERROR   | [x] Expected one space after the comma, 0 found
 122 | ERROR   | [ ] Missing short description in doc comment
 153 | ERROR   | [x] Expected one space after the comma, 0 found
 156 | ERROR   | [x] Whitespace found at end of line
 158 | WARNING | [ ] Only string literals should be passed to t() where possible
 161 | WARNING | [ ] Only string literals should be passed to t() where possible
------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------

The issue can be closed, as similar issue is reported in Document OCR Mindee Phpcs Issues 📌 Fix the issues reported by phpcs Needs review

The MR fixes all the reported phpcs issues, RTBC +1.
Thank you.

Found the following phpcs issue in the MR #5

FILE: /home/contribution/drupal/web/modules/contrib/document_ocr_mindee/src/Mindee.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\document_ocr_mindee\Repository\ApisRepository.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

Thanks @apaderno for the suggestions, I've updated the MR, Please review the MR.
Thank you.

Thanks @apaderno for the suggestions, I've updated the MR, Please review the MR.
Thank you.

I've fixed the phpcs issues, Please review the MR.
Thank you.

I've fixed the remaining phpcs issues, Please review the MR.
Thank you.

Showing following phpcs issues errors MR #2

FILE: ...e/contribution/drupal/web/modules/contrib/imageapi_optimize_webp/modules/imageapi_optimize_webp_responsive/imageapi_optimize_webp_responsive.module
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------
  9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface.
 35 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 55 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
 68 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
 72 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/imageapi_optimize_webp/src/Entity/ImageAPIOptimizeWebPPipeline.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\File\FileSystemInterface.
 18 | ERROR | [ ] Parameter tags must be defined first in a doc comment
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------

The phpcs issues have been resolved in other reported issue, PHPCS Issues 📌 Fix the errors/warnings reported by PHP_CodeSniffer Needs review

The possible useless methods were empty validate form methods in 'Form' files, and a separate 'setup()' method call without any definitions, hence can be removed. Please review the MR, Thank you.

Getting following errors in the issue's fork commit #3,

FILE: /home/contribution/drupal/web/modules/contrib/chat_ai/tests/src/Functional/SettingsPageTest.php
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 35 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/chat_ai/src/Form/SettingsForm.php
----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------
 91 | WARNING | Possible useless method overriding detected
----------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/chat_ai/src/Form/EmbeddingsForm.php
------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------
 231 | WARNING | Possible useless method overriding detected
------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/chat_ai/src/Form/ChatBlockForm.php
-----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
 141 | WARNING | Possible useless method overriding detected
-----------------------------------------------------------------------------------------

Hi @Nikolay Shapovalov, when I removed the trailing commas, there were no phpcs issues warnings/errors, but when I ran the phpstan, It gave errors for the trailing commas (which can effect the functionality), hence we can leave it, Thank you.

The following values can be removed:

FILE: /home/contribution/drupal/web/modules/contrib/weather_wave/src/Form/WeatherWaveForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 108 | WARNING | Unused variable $form_value.
 110 | WARNING | Unused variable $article_id.
 124 | WARNING | Unused variable $cityFieldValue.
 -----------------------------------------------------------------------------------------------------------------------------------------

Except these issues, remaining phpcs issues are fixed, please review the MR.
Thank you.

#5 fixes some phpcs issues, The following errors are still showing:

FILE: /home/contribution/drupal/web/modules/contrib/weather_wave-3390078/src/Plugin/Block/WeatherWaveBlock.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------
 41 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 42 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 42 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 43 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 47 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 53 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/weather_wave-3390078/src/Controller/WeatherForecastController.php
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 22 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/weather_wave-3390078/src/Form/WeatherWaveForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 65 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 80 | WARNING | Unused variable $form_value.
 82 | WARNING | Unused variable $article_id.
 96 | WARNING | Unused variable $cityFieldValue.
 96 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/weather_wave-3390078/weather_wave.routing.yml
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 8 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
-----------------------------------------------------------------------------------------------------------------

Hi @Nikolay Shapovalov, Thanks for the suggestion, The MR is divided into two separate commits, one for phpcs and other dependency injection changes, Please review the MR, Thank you.

I've fixed phpcs issues in files, Please review the MR.
Thank you.

The issue is part of PHPCS Report issue, which is reported earlier in PHPCS Issues 📌 Fix the errors/warnings reported by PHP_CodeSniffer Needs review

The issue is resolved.

I'll update it

Thanks @Nikolay Shapovalov, I've made changes in the MR as per your suggestions, Please review the updated MR.
Thank you.

Thanks @Nikolay Shapovalov, I've updated as per your suggestions, Please review the updated MR.
Thank you.

Please review the updated MR, Thank you.

Thanks @Nikolay Shapovalov, I'll update the MR as per your suggestions.

Thanks @Nikolay Shapovalov, As per your suggestions, I've reverted the changes in the File,
\tests\src\FunctionalJavascript\ViewsReferenceTest.php
Please review the MR, Thank you.

I'll create MR to fix the phpcs issues.

realsp → created an issue.

I've fixed the phpcs issues, please review the MR.
Thank you.

I'll create MR to fix the phpcs issues.

realsp → created an issue.

I've fixed the phpcs issues, Please review the MR.
Thank you.

I'll create MR to fix the phpcs issues.

realsp → created an issue.

FILE: /home/contribution/drupal/web/modules/contrib/stripe_gateway-3415165/README.md
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 61 | WARNING | Line exceeds 80 characters; contains 103 characters
----------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/stripe_gateway-3415165/src/Controller/StripeWebhookController.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 147 | WARNING | Unused variable $event.
-------------------------------------------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/stripe_gateway-3415165/src/Controller/StripeCheckoutController.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------
 298 | WARNING | Line exceeds 80 characters; contains 86 characters
 426 | ERROR   | Missing parameter type
--------------------------------------------------------------------------------------------------------------------------------


FILE: /home/contribution/drupal/web/modules/contrib/stripe_gateway-3415165/src/StripeServiceApi.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------
 152 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 172 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 183 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------

I've fixed the remaining phpcs issues, The above mentioned phpcs issues are not updated, because of the following reasons:

1. Line exceeds warnings are more readable with the existing characters.
2. Missing Parameter Type (The parameter is of ID, since it's a third-party ID, it can be integer or string)
3. \Drupal calls services are third-party services as these are not mentioned in the '.services.yml' file (which can be used for Dependency Injection Class)

Please review the MR, Thank you.

I'll create MR to fix these phpcs issues.

realsp → created an issue.

Similar issue has been raised in SynPrices Phpcs Errors 📌 Fix the errors/warnings reported by PHP_CodeSniffer Needs review .

I've fixed the phpcs issues, Please review the MR.
Thank you.

I'll create MR to fix the phpcs issues

realsp → made their first commit to this issue’s fork.

Hi @clarkssquared, Thank you for sharing the remaining phpcs issues, The errors in .info file can be ignored as they are added automatically (These lines are not being added in the forked branch). Please review the MR, Thank you.

I've fixed the phpcs issues, Please review the MR.
Thank you.

realsp → created an issue.

I've fixed the phpcs issues, Please review the MR.
Thank you.

realsp → created an issue. See original summary → .

I've fixed the phpcs issues, Please review the MR.
Thank you.

realsp → created an issue.