- Issue created by @sidharth_soman
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 5:24am 11 April 2023 - š®š³India sidharth_soman Bangalore
I have issued an MR for the above issues. Please review.
- š®š³India realsp
Showing following phpcs issues errors MR #2
FILE: ...e/contribution/drupal/web/modules/contrib/imageapi_optimize_webp/modules/imageapi_optimize_webp_responsive/imageapi_optimize_webp_responsive.module ------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface. 35 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 55 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters 68 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters 72 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters ------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /home/contribution/drupal/web/modules/contrib/imageapi_optimize_webp/src/Entity/ImageAPIOptimizeWebPPipeline.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\File\FileSystemInterface. 18 | ERROR | [ ] Parameter tags must be defined first in a doc comment ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------
- š®š³India realsp
I've fixed the remaining phpcs issues, Please review the MR.
Thank you. - Status changed to Needs work
12 months ago 10:13pm 24 January 2024 - Assigned to realsp
- Issue was unassigned.
- š®š³India realsp
Thanks @apaderno for the suggestions, I've updated the MR, Please review the MR.
Thank you. - Status changed to Needs review
12 months ago 6:44am 25 January 2024 - Status changed to Needs work
5 months ago 1:58am 14 August 2024 Hi @realsp,
The latest changes you made on MR!10 was applied not-so successfully, some files failed to apply. Might be the reason the error below were still reported, please see:
imageapi_optimize_webp git:(2.0.x) curl https://git.drupalcode.org/project/imageapi_optimize_webp/-/merge_requests/10.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 8192 0 8192 0 0 25229 0 --:--:-- --:--:-- --:--:-- 25924 patching file imageapi_optimize_webp.module Hunk #1 succeeded at 3 with fuzz 2 (offset 2 lines). Hunk #2 FAILED at 15. 1 out of 2 hunks FAILED -- saving rejects to file imageapi_optimize_webp.module.rej patching file imageapi_optimize_webp.services.yml patching file modules/imageapi_optimize_webp_responsive/imageapi_optimize_webp_responsive.module patching file src/Controller/ImageStyleDownloadController.php patching file src/Entity/ImageAPIOptimizeWebPPipeline.php patching file src/Plugin/ImageAPIOptimizeProcessor/WebP.php ā imageapi_optimize_webp git:(2.0.x) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig imageapi_optimize_webp FILE: ...9/web/modules/contrib/imageapi_optimize_webp/imageapi_optimize_webp.module -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 204ms; Memory: 10MB
Kindly check
Thanks,
Jake- Merge request !17Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix ā (Open) created by apaderno
- š®š¹Italy apaderno Brescia, š®š¹
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3353336-gitlab-ci-reports to hidden.
- Status changed to Needs review
5 months ago 10:39am 14 August 2024