Fix the issues reported by phpcs

Created on 11 April 2023, almost 2 years ago
Updated 14 August 2024, 5 months ago
šŸ“Œ Task
Status

Needs review

Version

2.0

Component

Code

Created by

šŸ‡®šŸ‡³India sidharth_soman Bangalore

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @sidharth_soman
  • Merge request !10Fixed phpcs issues. ā†’ (Open) created by sidharth_soman
  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • šŸ‡®šŸ‡³India sidharth_soman Bangalore

    I have issued an MR for the above issues. Please review.

  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • šŸ‡®šŸ‡³India realsp

    Showing following phpcs issues errors MR #2

    FILE: ...e/contribution/drupal/web/modules/contrib/imageapi_optimize_webp/modules/imageapi_optimize_webp_responsive/imageapi_optimize_webp_responsive.module
    ------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
    ------------------------------------------------------------------------------------------------------------------------------------------------------------
      9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface.
     35 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
     55 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
     68 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
     72 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
    ------------------------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /home/contribution/drupal/web/modules/contrib/imageapi_optimize_webp/src/Entity/ImageAPIOptimizeWebPPipeline.php
    -------------------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    -------------------------------------------------------------------------------------------------------------------------------
      6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\File\FileSystemInterface.
     18 | ERROR | [ ] Parameter tags must be defined first in a doc comment
    -------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------------------------
    
  • šŸ‡®šŸ‡³India realsp

    I've fixed the remaining phpcs issues, Please review the MR.
    Thank you.

  • Status changed to Needs work 12 months ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Assigned to realsp
  • Issue was unassigned.
  • šŸ‡®šŸ‡³India realsp

    Thanks @apaderno for the suggestions, I've updated the MR, Please review the MR.
    Thank you.

  • Status changed to Needs review 12 months ago
  • Status changed to Needs work 5 months ago
  • Hi @realsp,

    The latest changes you made on MR!10 was applied not-so successfully, some files failed to apply. Might be the reason the error below were still reported, please see:

     imageapi_optimize_webp git:(2.0.x) curl https://git.drupalcode.org/project/imageapi_optimize_webp/-/merge_requests/10.diff | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  8192    0  8192    0     0  25229      0 --:--:-- --:--:-- --:--:-- 25924
    patching file imageapi_optimize_webp.module
    Hunk #1 succeeded at 3 with fuzz 2 (offset 2 lines).
    Hunk #2 FAILED at 15.
    1 out of 2 hunks FAILED -- saving rejects to file imageapi_optimize_webp.module.rej
    patching file imageapi_optimize_webp.services.yml
    patching file modules/imageapi_optimize_webp_responsive/imageapi_optimize_webp_responsive.module
    patching file src/Controller/ImageStyleDownloadController.php
    patching file src/Entity/ImageAPIOptimizeWebPPipeline.php
    patching file src/Plugin/ImageAPIOptimizeProcessor/WebP.php
    āžœ  imageapi_optimize_webp git:(2.0.x) āœ— ..
    āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig imageapi_optimize_webp
    
    FILE: ...9/web/modules/contrib/imageapi_optimize_webp/imageapi_optimize_webp.module
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     1 | ERROR | [x] Missing file doc comment
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    Time: 204ms; Memory: 10MB

    Kindly check

    Thanks,
    Jake

  • Pipeline finished with Success
    5 months ago
    Total: 243s
    #253755
  • Pipeline finished with Success
    5 months ago
    Total: 489s
    #253754
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    avpaderno ā†’ changed the visibility of the branch 3353336-gitlab-ci-reports to hidden.

  • Status changed to Needs review 5 months ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Pipeline finished with Success
    5 months ago
    Total: 125s
    #253774
Production build 0.71.5 2024