- Issue created by @realsp
- Assigned to realsp
- Issue was unassigned.
- Status changed to Needs review
11 months ago 9:33am 15 January 2024 - š®š³India realsp
I've fixed the phpcs issues, Please review the MR.
Thank you. - Status changed to Needs work
11 months ago 8:42am 16 January 2024 - šµšPhilippines clarkssquared
Hi
I applied your MR !1 and I noticed that there are still many PHPCS issues in the module
ā email_validate git:(master) ā curl https://git.drupalcode.org/project/email_validate/-/merge_requests/1.diff | pa tch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3873 0 3873 0 0 8017 0 --:--:-- --:--:-- --:--:-- 8119 patching file 'src/Form/EmailValidateForm.php' ā email_validate git:(master) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml email_validate FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/email_validate/README.md ------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------- 1 | WARNING | Line exceeds 80 characters; contains 121 characters 2 | WARNING | Line exceeds 80 characters; contains 110 characters 19 | WARNING | Line exceeds 80 characters; contains 119 characters 31 | WARNING | Line exceeds 80 characters; contains 84 characters ------------------------------------------------------------------------------------------------- FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/email_validate/email_validate.info.yml --------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically --------------------------------------------------------------------------------------------------------------- FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/email_validate/email_validate.module -------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------- 24 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for | | xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements | | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block | | templates." 26 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 34 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- Time: 302ms; Memory: 10MB
- Assigned to realsp
- š·šŗRussia _cosmos_ Izhevsk, Russia
Thanks for your contribution, guys!
When you fix these notices I will create the new release - Issue was unassigned.
- Status changed to Needs review
11 months ago 1:08pm 16 January 2024 - š®š³India realsp
Hi @clarkssquared, Thank you for sharing the remaining phpcs issues, The errors in .info file can be ignored as they are added automatically (These lines are not being added in the forked branch). Please review the MR, Thank you.
- Status changed to Needs work
11 months ago 7:46pm 19 January 2024 - š·šŗRussia zniki.ru
I left feedback in the MR, set to NW.
Please update IS - renew the phpcs report.
Suggested command to run phpcs
phpcs --standard=Drupal,DrupalPractice --extensions=php,inc,module,install,info,test,profile,theme
- Assigned to realsp
- Issue was unassigned.
- Status changed to Needs review
11 months ago 7:38am 23 January 2024 - š®š³India realsp
Thanks @Nikolay Shapovalov, I've made changes in the MR as per your suggestions, Please review the updated MR.
Thank you. - Status changed to Needs work
11 months ago 7:59am 23 January 2024 - š·šŗRussia zniki.ru
Thanks, please update phpcs report in the IS, and check my feedback at the MR.
- Status changed to Needs review
11 months ago 4:53pm 23 January 2024 - Status changed to RTBC
11 months ago 9:47pm 23 January 2024 - Status changed to Fixed
9 months ago 6:30am 21 March 2024 - š·šŗRussia _cosmos_ Izhevsk, Russia
Well guys,
Thanks a lot for your time, all fixes was applied in new 1.0.5 release of the module.
Checking out the commits https://git.drupalcode.org/project/email_validate/-/commits/1.0.x?ref_ty... - Status changed to Fixed
9 months ago 1:58pm 2 April 2024