- Issue created by @sidharth_soman
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 2:14pm 5 July 2023 - š®š³India sidharth_soman Bangalore
I have fixed all the issues except the use of dsm(). Leaving it as it is for debugging purposes.
Please review the MR
- Assigned to realsp
- Status changed to Needs work
11 months ago 12:50pm 30 January 2024 - š®š³India realsp
Found the following phpcs issues in MR #2,
FILE: /home/contribution/drupal/web/modules/contrib/phpmail_alter/src/Service/PhpMail.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface. ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /home/contribution/drupal/web/modules/contrib/phpmail_alter/src/Service/DebugService.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Extension\ModuleHandlerInterface. 95 | WARNING | [ ] The use of function dsm() is discouraged ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -----------------------------------------------------------------------------------------------------------------------------------------
- š®š³India realsp
I'll update the MR to fix the remaining phpcs issues.
- Issue was unassigned.
- Status changed to Needs review
11 months ago 1:10pm 30 January 2024 - š®š³India realsp
I've fixed the remaining phpcs issues in MR, Please review the MR.
Thank you. - Status changed to RTBC
11 months ago 7:16am 1 February 2024 - šµšPhilippines clarkssquared
Hi
I applied the MR !1 after commit number 6 and I confirmed that it fixes all the PHPCS issues
ā phpmail_alter git:(8.x-1.20) curl https://git.drupalcode.org/project/phpmail_alter/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 4408 0 4408 0 0 7762 0 --:--:-- --:--:-- --:--:-- 7871 patching file phpmail_alter.services.yml patching file 'src/Service/DebugService.php' patching file 'src/Service/PhpMail.php' ā phpmail_alter git:(8.x-1.20) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml phpmail_alter ā contrib git:(master) ā