Fix the errors/warnings reported by PHP_CodeSniffer

FILE: /home/contribution/drupal/web/modules/contrib/invoicexpress_api/invoicexpress_api.services.yml -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 13 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: /home/contribution/drupal/web/modules/contrib/invoicexpress_api/src/InvoicExpressEstimatesService.php --------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES --------------------------------------------------------------------------------------------------------------------- 86 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 96 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 121 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 130 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 187 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 197 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 230 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 240 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 265 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 275 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 299 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 308 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 347 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 357 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------------------------- FILE: /home/contribution/drupal/web/modules/contrib/invoicexpress_api/src/InvoicExpressClientsService.php ------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES ------------------------------------------------------------------------------------------------------------------- 56 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 65 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 87 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 96 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 135 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 145 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 186 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 196 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 218 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 227 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 249 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 258 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 293 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 303 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------- FILE: /home/contribution/drupal/web/modules/contrib/invoicexpress_api/src/InvoicExpressSequencesService.php --------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------- 52 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 61 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------------------------- FILE: /home/contribution/drupal/web/modules/contrib/invoicexpress_api/src/InvoicExpressInvoicesService.php -------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 16 WARNINGS AFFECTING 16 LINES -------------------------------------------------------------------------------------------------------------------- 88 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 98 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 155 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 165 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 189 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 198 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 220 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 229 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 254 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 264 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 300 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 310 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 350 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 360 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 384 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 393 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead -------------------------------------------------------------------------------------------------------------------- FILE: /home/contribution/drupal/web/modules/contrib/invoicexpress_api/invoicexpress_api.module ------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------ 21 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "invoicexpress_handle_response" but expected | | "invoicexpress_api_invoicexpress_handle_response" ------------------------------------------------------------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @realsp
Assigned to realsp
Comment 10 months ago →
🇮🇳India realsp
I'll create MR to fix the phpcs issues.
Merge request !5Fixed phpcs issues in files → (Merged) created by realsp
Issue was unassigned.
Comment 10 months ago →
🇮🇳India realsp
I've fixed the phpcs issues, please review the MR.
Thank you.
Assigned to jmauricio
Status changed to Needs work 10 months ago10:45am 22 January 2024
Comment 10 months ago →
🇵🇹Portugal jmauricio
Issue was unassigned.
Status changed to Needs review 10 months ago10:47am 22 January 2024
Comment 10 months ago →
🇵🇹Portugal jmauricio
Changes merged into 1.0.x
Status changed to RTBC 10 months ago10:50am 22 January 2024
Comment 10 months ago →
🇵🇹Portugal falsovsky
Comment 7 months ago →
🇵🇹Portugal jmauricio
Status changed to Fixed 7 months ago8:10am 13 May 2024
Comment 7 months ago →
🇵🇹Portugal jmauricio

Fix the errors/warnings reported by PHP_CodeSniffer

Problem/Motivation

Steps to reproduce

Merge Requests

!5Fix the errors/warnings reported by PHP_CodeSniffer
Merged

Comments & Activities

Fix the errors/warnings reported by PHP_CodeSniffer

Problem/Motivation

Steps to reproduce

Merge Requests

!5Fix the errors/warnings reported by PHP_CodeSnifferMerged

Comments & Activities

!5Fix the errors/warnings reported by PHP_CodeSniffer
Merged