- Issue created by @shweta__sharma
- First commit to issue fork.
- Status changed to Needs review
6 months ago 5:42am 9 January 2024 - 🇮🇳India realsp
I've added conditions for the case scenario when there's no-content inside icon-box & markup enhancements, when there's no-description in the banner, Please review the MR, Thank you.
- Status changed to RTBC
6 months ago 12:56pm 9 January 2024 - 🇮🇳India Tirupati_Singh
Hi @realsp, I've test the changes made on MR#22 and confirm that the issue has been resolved. Attaching screenshot for reference.
- Merge request !233402795-banner-enhance: Resolved the banner slider component issue. → (Open) created by Tirupati_Singh
- Status changed to Needs review
6 months ago 4:58pm 9 January 2024 - 🇮🇳India Tirupati_Singh
Resolved the banner component issue using another approach, please review the changes.
- Status changed to RTBC
18 days ago 12:52pm 6 June 2024 Hi,
I've encountered the aforementioned issue, and after applying both the patches the issue is getting resolved.
Reviewed both the MR, both the MRs are looking good to me, but MR!23 provides a configuration option from the theme settings from which it lets the user to choose the number of slides, which not only solves the card rendering issue on the homepage, but also dynamically renders card components on the theme settings form based on the chosen value, for which it seems more of a robust solution to me!
Attaching before and after screenshots for reference!- 🇮🇳India Tirupati_Singh
@sourojeetpaul, thanks for the feedback. I've made changes for conditional rendering of banner title, banner description and banner slider. Please review the changes.