"Taxonomy term ID from URL" default views argument should have url.path as cache context, not url

Can you share proper reproducing steps?

@sourav_paul, For Drupal core, it is preferred that contributors add a comment that they are working on an issue instead of assigning it to themselves. See Assigning ownership of a Drupal core issue → .

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

Thanks @quietone, from nxt time will keep it in mind...

@sourav_paul: I could find no easy way to reproduce precisely this on a clean install (such as https://simplytest.me) because there must be other render elements in pages also depending on url cache context, not just this one. Thus I get a x-drupal-cache:miss HTTP header as soon as I add a new query arg (such as ?foo), even without using "Taxonomy term ID from URL" default views argument.

Okay I understand, But I don't feel its a good idea as if we cache url path with args, it could create problem with contextual filtration of view.

Welcome for Opinions...

I would argue it needs to vary by "route" instead. After all, core/modules/taxonomy/src/Plugin/views/argument_default/Tid.php uses the route match to get the data it needs to function.

P.S.: Just because a page is located at /myterms/42, does not mean the 42 will get translated into a taxonomy term. It needs a route parameter for that in the route behind the page. See Drupal\Core\ParamConverter\EntityConverter. (A custom ParamConverterInterface could also work but that's highly unusual.)