Vertical tab is visible when all items are hidden

MR8 is ready for review

Hi jannakha, do you have the patch? I need to apply this for my site.
Thank you very much <3

@octaviosch
patch is on MR - https://git.drupalcode.org/project/simplify/-/merge_requests/8.diff

please review docs on git workflow:
- https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →
- https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

After you install patch, please update status of this issue

dom. → made their first commit to this issue’s fork.

I am sorry, I could not get this to work. I still see an empty secondary bar with the advanced group div.

Thanks for the patch @jannakha

It works for me, revisions isn't showing anymore along with other selected fields to hide.

Before applying the patch on the branch 2.x:

After:

I see it working for the Revision field, but not for the Status metadata or Menu settings.

This is in my custom theme, however this is working in Claro, like the screenshots above.

I do see the wrapper being rendered, as @dom. mentioned.

Looks like I had a hand in this a while back: https://www.drupal.org/project/simplify/issues/3207027#comment-14243065 ✨ Hide last saved and author (meta) Fixed

Try testing in Stark, there are some differences in other themes. But both should be working.

Here in Claro, advanced and meta vertical tab groups are changed to container elements. Revision information is moved into the meta group.
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/themes/claro/...

It was not totally clear using this module that the fields would get a visually-hidden class. That's something to consider whether there are other implications, like users being able to change things manually.

In the last push, I made some adjustments that seem to work in stark and claro. I don't know why this mix of type = hidden and class = visually-hidden are needed, but using one or the other did not work. I set path to be the same way.

Is it better to use access = false like path had?

Linking a core issue.

Linking another core issue.

I think there should be a more robust way to manage the vertical tabs, like on the manage display form. That would resolve a lot of related problems.

Hi there,

I prepared another solution with the 'Hide all fields' setting to hide the whole advanced section instead of hiding fields.

Please check if it works for you.
thanks

Hi
I have tested MR 11 on Drupal 10.3
MR is applied successfully...

The 'Hide all fields' is available in setting and the sidebar is able to hide with configuration.

But MR showing open pipeline issue, for that keeping in needs review for code verification

Thanks for your contribution!

the failed MR status points to a failed unit test - please fix the test.

Thanks for reviewing it

refs to tests, I already created another issue to fix tests - 🐛 Fix phpunit tests Active

As you can see, it fails because of Drupal core changes and is not related to the current issue changes.
the MR for reference - https://git.drupalcode.org/project/simplify/-/merge_requests/12 (no changes in module but failed tests)