- Issue created by @spryah
- First commit to issue fork.
- Merge request !127Issue #3488134: Add type="button" to action buttons → (Merged) created by sourav_paul
- 🇫🇷France just_like_good_vibes PARIS
postponed because current branch 1.1.x has target DSFR 1.12,
and DSFR 1.13 is still under progress (unreleased) - 🇫🇷France spryah
Hello @sourav_paul
Thank you for taking charge of this issue!
The changes look good except for the following file:templates/system/input--submit--search-submit.html.twig
This is an actual submit button, which will receive thetype="submit"
attribute, so it should be best to revert just this partHello @just_like_good_vibes
I initially associated the issue with DSFR v1.13 but this is actually an issue that already causes trouble whenever one of these components are inside a form, so I believe that it should be addressed regardless of the DSFR version - 🇫🇷France just_like_good_vibes PARIS
we need to address this more carefully, the initial work posted by sourav_paul did not carefully check for existing attributes in the tags.
-
just_like_good_vibes →
committed 6bae7794 on 1.1.x authored by
sourav_paul →
Issue #3488134 by just_like_good_vibes, sourav_paul, spryah: Add type="...
-
just_like_good_vibes →
committed 6bae7794 on 1.1.x authored by
sourav_paul →