Locale settings not respected when installing via existing configuration

The configuration part is a non-issue, as it is applied later in the process, so the only issue is just duplicating the constant in code.

This can be either a really easy fix or a won't fix, but I'll put it for review in any case.

Seems straight forward enough.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Just did a rebase. Back to RTBC.

Let's move the constant. This is something we need earlier than the module system being available because we download translations in the very very early installer. Therefore let's deprecate LOCALE_TRANSLATION_DEFAULT_SERVER_PATTERN and move the constant to \Drupal::TRANSLATION_DEFAULT_SERVER_PATTERN or somewhere else. Including all the locale module code throughout the installation process doesn't feel the correct approach.

I made a comment in the MR, it still needs some minor clean up.

I made MR suggestions for the code to address my feedback and @alexpott's feedback.

The @deprecate tag seems to require a change record node to be created.

Change record created, I'm not sure if this is the expected format: https://www.drupal.org/node/3488133 →

Most likely missed 11.1 window mind updating for 11.2, @fjgarlin feel free to ping me to re-look at quicker for you.

fjgarlin → changed the visibility of the branch 11.x to hidden.

fjgarlin → changed the visibility of the branch 3477277-locale-settings-not to hidden.

When rebasing, it was getting a conflict on files that were not modified by this MR, so rather than going into a rabbit hole, I created a new branch/MR with the same changes: https://git.drupalcode.org/project/drupal/-/merge_requests/10419 (old MR for reference)

As per #15, I'll ping @smustgrave for review.

smustgrave → closed merge request !9650

Manually updated deprecation for 11.2 but rest seems good.