- Issue created by @Anybody
- Assigned to sourav_paul
- 🇺🇸United States greggles Denver, Colorado, USA
Before adding the trim, we need to check that the value isn't already given trimmed!
I think trims are pretty fast and do no harm to strings that don't need them. Why bother with the check?
- Merge request !47Issue #3461965: Trim whitespace around email / name → (Open) created by sourav_paul
- Issue was unassigned.
- Status changed to Needs review
3 months ago 9:20am 18 July 2024 - Status changed to RTBC
3 months ago 8:37am 22 July 2024 - Status changed to Needs work
8 days ago 1:20pm 10 October 2024 - 🇩🇪Germany Anybody Porta Westfalica
Sadly this isn't working. Tests fail and say
Exception: Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated
email_registration_user_login_validate()() (Line: 263) - 🇩🇪Germany Anybody Porta Westfalica
Ok tests are green now, back to needs review.