stylelint-formatter-gitlab prevents updating stylelint

With the upcoming releases of 10.4.0 and 11.1.0 this issue is as hot as ever.

spokje → closed merge request !10132

spokje → closed merge request !10131

MR !10129 shows that when there are no errors, stuff doesn't break.

This run of another issue show that it can actually detect and report issues: https://git.drupalcode.org/issue/drupal-3487817/-/pipelines/340184/codeq...

That report does indeed look like the example report given here: https://gitlab.com/gitlab-formatters/stylelint-formatter-gitlab/-/merge_...

Mirroring status of parent issue, which became critical.

So the output is slightly different now but I think for the better

before

  <file name="/var/www/html/web/core/misc/dialog/off-canvas/css/titlebar.pcss.css"></file>
  <file name="/var/www/html/web/core/misc/dialog/off-canvas/css/utility.css"></file>
  <file name="/var/www/html/web/core/misc/dialog/off-canvas/css/utility.pcss.css"></file>
  <file name="/var/www/html/web/core/misc/dialog/off-canvas/css/wrapper.css"></file>
  <file name="/var/www/html/web/core/misc/dialog/off-canvas/css/wrapper.pcss.css"></file>
  <file name="/var/www/html/web/core/themes/claro/css/base/elements.css"></file>
  <file name="/var/www/html/web/core/themes/claro/css/base/elements.pcss.css">
    <error source="stylelint.rules.order/properties-order" line="7" column="3" severity="error" message="Expected &quot;font-family&quot; to come before &quot;font-style&quot; (order/properties-order)" />
  </file>
  <file name="/var/www/html/web/core/themes/claro/css/base/print.css"></file>
  <file name="/var/www/html/web/core/themes/claro/css/base/print.pcss.css"></file>

After

> lint:css-checkstyle
> stylelint "**/*.css" --custom-formatter=@gitlab-formatters/stylelint-formatter-gitlab --output-file=gl-codequality.json

[{"type":"issue","check_name":"order/properties-order","description":"Expected \"font-family\" to come before \"line-height\" (order/properties-order)","content":{"body":"Error found in order/properties-order."},"categories":["Style"],"location":{"path":"themes/claro/css/base/elements.pcss.css","lines":{"begin":7,"end":7},"positions":{"begin":{"line":7,"column":3},"end":{"line":7,"column":35}}},"s

But more importantly it found the error I introduced.

IMHO the output on GitLab is what matters, the grimy internal format to get there is less relevant.
The output on GitLab is advertised in its own repo as looking something like this:
Screenshot from repo

And in our own drupal CSS Linting job: https://git.drupalcode.org/issue/drupal-3487817/-/pipelines/340184/codeq...

In the interests of unblocking the Stylelint upgrade let's get this in now. I think the output could be improved - we should fix up the paths so the link in https://git.drupalcode.org/issue/drupal-3487817/-/pipelines/340184/codeq... is clickable - but that can happen in a followup.

Committed and pushed to 11.x and 11.1.x, thanks! Marking PTBP for backport to 10.5.x and 10.4.x.

spokje → changed the visibility of the branch 11.x to hidden.

spokje → changed the visibility of the branch 3467309-stylelint-formatter-gitlab-prevents-updating to hidden.

Follow-up issue created: 📌 Link output of CSS eslinting on GitLab correctly Active

working on to port changes into 10.4.x

sourav_paul → changed the visibility of the branch 11.x to active.

sourav_paul → changed the visibility of the branch 11.x to hidden.

Re-rolls seem fine.

@sourav_paul the 10.5.x patch applies fine to 10.4.x, there was no need to open a separate MR.

Committed and pushed 07aa9ecb2f7 to 10.5.x and 4079ec4a177 to 10.4.x. Thanks!

longwave → closed merge request !10344

longwave → closed merge request !10337

Automatically closed - issue fixed for 2 weeks with no activity.