- Status changed to Needs review
over 1 year ago 8:48pm 1 May 2023 - Status changed to Needs work
over 1 year ago 8:51pm 1 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ * The user Entity. + * + * @var \Drupal\user\Entity\User + */ + protected $user; +
Entity is misspelled.
+ /** + * Create dependency injection for class. + */ + public static function create(ContainerInterface $container) {
It is sufficient to use
{@inheritDoc}
. - Assigned to himanshu_jhaloya
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:49am 2 May 2023 - 🇮🇳India himanshu_jhaloya Indore
Created a patch for the commented issue. please review
- Status changed to Needs work
over 1 year ago 9:33pm 3 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ * @param \Drupal\user\Entity\User $user + * The user Entity.
Only the first word in a sentence is capitalized.
+ /** + * {@inheritdoc} + */ + + public static function create(ContainerInterface $container) {
There must not be empty lines between a method declaration and the documentation comment.
- Status changed to Needs review
over 1 year ago 7:37am 5 May 2023 - 🇮🇳India himanshu_jhaloya Indore
create a patch to fix the above issue. please review
- Status changed to Needs work
over 1 year ago 7:43am 5 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The patch must include all the changes, not just the ones reported in the last comment.
- Assigned to sourabhjain
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:06am 22 June 2023 - Status changed to RTBC
over 1 year ago 1:29am 23 June 2023 - 🇵🇭Philippines paraderojether
I update the summary since I'm getting different phpcs issues results after running this command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig w3c_validator.
I also reviewed patch #17, applied against W3C Validator 8.x-1.x-dev, and confirmed it fixes the issues reported by phpcs.
I added screenshots for reference.
Thank You. - Status changed to Needs work
over 1 year ago 4:42pm 23 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- public function __construct(Connection $database, AccountInterface $current_user) { + public function __construct(Connection $database, AccountInterface $current_user, User $user) { $this->database = $database; $this->currentUser = $current_user; + $this->user = $user; + } + + /** + * {@inheritdoc} + */ + public static function create(ContainerInterface $container) { + + return new static( + $container->get('current_user') + ); +
create()
must pass three arguments to the constructor, not one. - Status changed to Needs review
over 1 year ago 7:06am 25 June 2023 - 🇮🇳India bharath-kondeti Hyderabad
Addressed #19 and updated the patch. Please review.
- Status changed to Needs work
over 1 year ago 7:54am 25 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- return User::load($result->uid); + return $this->currentUser->load($result->uid);
That is not how a user account is loaded from the database. The current_user service is only for the currently logged-in user account; the class implementing that service does not even have a
load()
method. - Status changed to Needs review
over 1 year ago 6:55am 28 June 2023 - Status changed to Needs work
over 1 year ago 9:29am 28 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The last patch does not fix the User::load calls should be avoided in classes, use dependency injection instead warning for the
W3CTokenManager
class. - Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:46am 28 June 2023 - Status changed to Closed: outdated
over 1 year ago 10:05am 22 July 2023