- Issue created by @majmunbog
- last update
4 months ago 791 pass - Status changed to Needs review
4 months ago 8:52am 21 February 2024 -
jsacksick →
committed b896bf80 on 8.x-2.x authored by
majmunbog →
#3422636: CSS, template and library cleanup.
-
jsacksick →
committed b896bf80 on 8.x-2.x authored by
majmunbog →
-
jsacksick →
committed 24111176 on 3.0.x authored by
majmunbog →
#3422636: CSS, template and library cleanup.
-
jsacksick →
committed 24111176 on 3.0.x authored by
majmunbog →
- Status changed to Fixed
about 1 month ago 9:05am 13 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- 🇺🇸United States andyg5000 North Carolina, USA
Hey Guys, Thanks for the work on this. This requires an update for anyone that's customized the admin order template. May want to put something in the release notes about that.
- 🇮🇱Israel jsacksick
Perhaps removing the libraries was too brutal... Did that cause you any trouble? But I guess even keeping the files would have been problematic, since the libraries.yml definition was removed right?
- 🇺🇸United States andyg5000 North Carolina, USA
It just broke the column layout on our admin order page. Not a big deal imo, but end users did have a moment of panic. Just a heads up to check custom templates in the release notes should be fine I think.
- 🇺🇸United States andyg5000 North Carolina, USA
I've had complaints about `--commerce--layout-content-max-width` too. Not sure why that's constrained to 52rem. It affects the column layout of all the commerce pages like product edit form and order edit form.
- 🇮🇱Israel jsacksick
The Claro approach was copied, there was a followup issue addressed as the width got reduced on the order view page accidentally too. I'm also not a huge fan of the restricted width for the edit forms, but I guess we just followed Claro's lead.
- 🇮🇱Israel jsacksick
This is the followup issue for reference: 🐛 Main layout region is too narrow for our entity forms on wide screens Fixed .