Contrib.social

Remove width CSS property from numeric values in order total summary

Open on Drupal.org →
Created on 27 October 2020, about 4 years ago
Updated 6 June 2024, 6 months ago

Problem/Motivation

The numeric values with class order-total-line-value in the order total summary have a "width: 80px" CSS property set in modules/contrib/commerce/modules/order/css/commerce_order.total_summary.css
I can't think of a reason why we would limit the width of those numeric values by default. For my projects 80px always proves too short for HUF. I guess it's the same for any currency with longer numbers.
It's not a big issue and it's easy to fix with custom CSS but I think it should look nice out of the box.

Proposed resolution

Let's remove that width property from the numeric values so they can be as wide as they want.
Let's also add a left and right padding to the value labels next so it looks nice by default.

Another possible resolution

If we want the value labels to line up with each other while aligned right, another solution might be to increase the 80px to a bigger value. It's impossible to say what value will be enough for all use cases though...

🐛 Bug report
Status

Fixed

Version

2.0

Component

Checkout

Created by

🇭🇺Hungary dr. gubó

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024