🇭🇺Hungary @dr. gubó

dr. gubó → created an issue.

We have a few submissions with the same problem, that the payment got through but no form submission was registered. These happened on a form that used cards.

After removing all cards elements from the form and making it just a regular form with no going back and forth through pages, and doing a few rounds of manual testing, here's what I found.

With AJAX disabled for the webform

• filled out some details, but left some required fields empty
• entered my (test) card details and clicked the submitt button
• the title of the submit button changed to "Processing payment" and the button became disabled, but the form wasn't submitted, and threw me the (inline) form errors for the missing required fields
• at this point, the card payment has gone through, I can see it as completed on the Stripe dashboard
• the submit button text is still "Processing payment" and the button is still disabled, so I'm not able to actually submit the form
• in the end I have a successful payment without a corresponding form submission

Same form and test process with AJAX enabled

• on the first submit with missing required fields but filled out card details, no actual payment happens
• until I have missing required fields, the submit button title doesn't change to "Processing payment" on submit attempt even if card details are already entered, and I get the error messages for the missing fields
• BUT the page doesn't scroll back up to the first missing field, which it does when I submit with AJAX disabled. I think this would be crucial because otherwise the visitor has no feedback about what's wrong, they only see that the submit button at the end of the form does nothing.
• still, after modifying form values (filling out missing fields) I can submit the form, and the button title changes to "Processing payment"
• payment goes through, I'm redirected to the confirmation page, all good

So it looks like AJAX has to be enabled for proper functionality, but enabling AJAX comes with the serious downside of preventing scrollback to the missing required fields.

Hope this helps in tracking the problem down.

This would also solve Allow booking of whole days ✨ Allow booking of whole days Active without introducing any new operation logic.

- Selecting another month or day on the widget should not reset the text field that stores the already selected value
- We should consider how it's best to display any selected values that are not submitted yet. If we select a slot from one day and then change the widget to another day, the selected slot should stay visible in some form.

dr. gubó → created an issue.

Hiding the initial patch as it breaks module functionality and attaching new a patch that:

• modifies core_version_requirement to include D10
• replaces deprecated module_load_include() with \Drupal::moduleHandler()->loadInclude()
• switches to itamair/geophp that's used by Geofield and drops phayes/geophp, as suggested in #8.

Please review.

Patch that fixes typo attached.

dr. gubó → created an issue.

I can confirm what #12 says, using the patch from merge request 16 broke the editing UI for all node types that had a Select2 widget. (Though weirdly only on our live site and not in our ddev dev environment. I didn't investigate the cause because the patch in the related issue seems to do the job.)