Drupal 10 readiness

As seen on the patch I upload,

- I've updated the info file.
- Since the module_load_include() is deprecated → , I've commented out relevant line.

After those things, I've checked the upgrade status report page, the local code is looks D10 Compatible.

Now I'm changing the issue status as Needs review.

Hi
The patch applied cleanly and doesn't show any D10 compatible issues while tested using Upgrade_status module.

Thanks

Hello @dineshkumarbollu,

Thank you for your comment and MR. do you have a special reason for not to change the status of the issue as RTBC?

Best,
Orkut

Hi Orkut Murat Yılmaz

No, I will move this to RTBC

Thanks

Hi,

Thanks for contributing, but it's not acceptable to "just comment out a line because of a deprecation". I don't understand how this has been set to RTBC... probably not tested on a real example.

A 5s google search indicates how to handle the deprecation -> https://www.drupal.org/node/2948698 →

Also, if one were curious, one would investigate whether we should use phayes' geophp or itamair's geophp. It seems to be similar, but geofield is using itamair's one (with reference to the phayes name in the code), and views_geojson is also using itamair (so probably makes sense to switch to itamair's to keep things clean)

Cheers

Hi

While I run the D10 compatible issues in the module I didn't found any Deprecated issues and upgrade status report shows compatible for D10 that reason i moved to RTBC, Can you tell exact issue in comment#8 i will look on it.

Thanks

The issue is from the original merge request

- Since the module_load_include() is deprecated, I've commented out relevant line.

And we can see in the patch (which is very small, it's actually one of the only 2 things changed):

 public function postExecute() {
-    module_load_include('inc', 'geofield', 'vendor/phayes/geophp/geoPHP');
+    //module_load_include('inc', 'geofield', 'vendor/phayes/geophp/geoPHP');
     $results_by_geohash = $this->preClusterByGeohash();

If this line was here in the first place, it means that it was useful ... you can't just comment it out.

@vdsh, thank you for your beautiful explanations. Also, thanks for letting me learn 5S too.

I'll refactor the patch, when I'm available.

Best,
Orkut

Hiding the initial patch as it breaks module functionality and attaching new a patch that:

• modifies core_version_requirement to include D10
• replaces deprecated module_load_include() with \Drupal::moduleHandler()->loadInclude()
• switches to itamair/geophp that's used by Geofield and drops phayes/geophp, as suggested in #8.

Please review.