Expand the ShipmentWeight condition to support ranges

After upgrading the Physical Fields module to 8.x-1.3 Patch in #8 gives an error. After the update, the Minimum and Maximum fields stopped appearing, and the old shipping methods did not work.

Just tested patch #8 again with Drupal 9.5.8 , Drupal Commerce 8.x-2.x-dev updated 7 Apr 2023

The patch still works.

I also found another module that can do the same thing here -> https://github.com/gnikolovski/commerce_gnikolovski

The module might be better for existing site since it provided you another new option Limit by shipment weight range in case you don't want current config to mixed up and got an error "Invalid weight unit "" provided." after patched.

I tested and reviewed Patch #8 and I can confirm that it's solving this issue.

Patch in #5 works and resolves the issue. Marking RTBC!

Wow, what a blast from the past! I literally said a little prayer before hitting enter and applying the patch from #8. It applied and on top of that it's working. Absolutely saved my life, I did not expect commerce shipping to not be able to handle different shipping rates for different weights.

The commerce shipping tariff module is either not working (it's in alpha) or wasn't designed to cover this use case. There is a commerce shipping linear weight module, which in its current incarnation does not support a base rate and assumes the weight and price increments to be, well, linear. This patch was the last and only hope.

I now need to make 122 shipping methods (viva the entity_clone module!) to cover all the weight ranges, but at least with this patch we can get the required functionality working and deliver the site.

Legendary patch!

What is the schedule to get this feature into the production release?

Well the patch has failing tests... And doesn't respect coding standards, so it is not RTBC.
Additionally, anybody applying the patch with existing shipment weight conditions is going to experience issues with it (configuration is going to be lost).

This change is a breaking change, it needs to be backwards compatible to support existing shipping methods using this condition...

I think the extra setting isn't required and make the UI more confusing...
We should probably simply override getComparisonOperators() to add extra operators.
Perhaps we should add "between" or 2 extra operators?

"< >" 
"<= >=" 

Not sure about the labeks. Perhaps "Between (exclusive)" and "Between (inclusive)"?

Just tested MR35 and it works great. New 2 options "Between (Inclusive)" and "Between (exclusive)" appear in the "Shipment > Shipment Weight -> Operator"

Merged! Thank you everyone!!

patch from #8 does not apply to commerce_shipping:8.x-2.9
Had to downgrade /src/Plugin/Commerce/Condition/ShipmentWeight.php to the version in commerce_shipping:8.x-2.8
Then apply patch #8.

How is that not available in 2.9? The change was committed? There are 2 new operators.

Automatically closed - issue fixed for 2 weeks with no activity.

@99gs3 I also noticed this but now you can use the "Between" operator to set a weight range.
Thanks for the work everyone. Happy to see this patch can be ditched after 6 years!

Initially I also thought that this was not functioning - but then I realised that I needed to rebuild all of the shipping rules that were using weight to use the new operators.

The patch that we had previously did not require this and I think that's where confusion may arise.