Recalculate shipping button blanks address when editing anon order shipments

I've tracked this down to the following code block being removed.
https://git.drupalcode.org/project/commerce_shipping/-/commit/3f492dc441...

If I restore that then the regression goes away.

The issue is that for whatever reason $address is empty even where there is a shipping profile already attached to the shipment. This happens when the order is owned by anonymous. Oddly this does not happen when the order is owned by a user, even if they have no shipping addresses in their address book and it's only the address stored on the shipment.

This is also a problem if a shipping profile is attached to the shipment during building of the form (via custom code) and the address is blown away by the recalculate button regardless of ownership of the order.

Here's a patch that "fixes" the problem by not touching the profile if the address is NULL.

The real fix will be figuring out why $address is empty and fixing that.

This patch is only to check failing test

@tBKoT: Please update an existing test, no need to define a new one, let's just expand ShipmentAdminTest. Besides, the tests-only patch doesn't seem to apply.

After spending time in the debugger and testing different scenarios I'm pretty sure I know what is wrong and needs to be fixed.

Setting the selected_profile_id for anonymous users technically works but is the wrong approach here. We only need to trigger the code that updates the current shipment profile when the selected profile changes. Since an anonymous order will never have a choice of profiles to select there is no reason to update the profile.

What does need to happen is if the user clicks the edit button and changes the address. The shipment profile does need to be updated with the changes before rate recalculation or you won't see updated rates. This will not happen because that was what `if ($address !== NULL) {$shipment->getShippingProfile()->get('address')->setValue($address);}` was intended to do and invoking the profile selection path will wipe out those changes.

Oops I left in some commented out code in that sample. This part needs to be removed

      // If a new address is being entered, empty the shipment profile so no rates are returned.
      //elseif (!empty($selected_profile_id) && $selected_profile_id === '_new') {
      //  $shipment->getShippingProfile()->set('address', NULL);
      //}

Committed, thanks everyone!

Automatically closed - issue fixed for 2 weeks with no activity.