Contrib.social

Fix the eslint issues

Open on Drupal.org ā†’
Created on 25 April 2024, 7 months ago
Updated 10 May 2024, 7 months ago

Describe your bug or feature request.

See https://git.drupalcode.org/project/commerce/-/jobs/1424995

*****************************************************************************************************************************
These are the current ESLINT errors and warnings 
*****************************************************************************************************************************
$ $CI_PROJECT_DIR/$_WEB_ROOT/core/node_modules/.bin/eslint --no-error-on-unmatched-pattern --ignore-pattern="*.es6.js" --resolve-plugins-relative-to=$CI_PROJECT_DIR/$_WEB_ROOT/core --ext=.js,.yml $_ESLINT_EXTRA . || true
/builds/project/commerce/web/modules/custom/commerce/modules/checkout/js/commerce_checkout.admin.js
   95:13  error  Prefer matches to $.is  jquery/no-is
  101:20  error  Prefer matches to $.is  jquery/no-is
/builds/project/commerce/web/modules/custom/commerce/modules/payment/js/offsite-redirect.js
  16:7  error  Prefer dispatchEvent + form.submit() to $.submit  jquery/no-submit
āœ– 3 problems (3 errors, 0 warnings)
$ printf "$DIVIDER\nNow running ESLINT using the --fix option. Any errors shown below are not fixable automatically.$DIVIDER\n"
 
*****************************************************************************************************************************
Now running ESLINT using the --fix option. Any errors shown below are not fixable automatically. 
*****************************************************************************************************************************
$ $CI_PROJECT_DIR/$_WEB_ROOT/core/node_modules/.bin/eslint --no-error-on-unmatched-pattern --ignore-pattern="*.es6.js" --resolve-plugins-relative-to=$CI_PROJECT_DIR/$_WEB_ROOT/core --ext=.js,.yml $_ESLINT_EXTRA --fix . || EXIT_CODE_FIX=$?
/builds/project/commerce/web/modules/custom/commerce/modules/checkout/js/commerce_checkout.admin.js
   95:13  error  Prefer matches to $.is  jquery/no-is
  101:20  error  Prefer matches to $.is  jquery/no-is
/builds/project/commerce/web/modules/custom/commerce/modules/payment/js/offsite-redirect.js
  16:7  error  Prefer dispatchEvent + form.submit() to $.submit  jquery/no-submit
āœ– 3 problems (3 errors, 0 warnings)
šŸ“Œ Task
Status

Fixed

Version

2.0

Component

Developer experience

Created by

šŸ‡®šŸ‡±Israel jsacksick

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024