Checkout flow items dragging broken and not saved

Patch based on changes in MR

Confirming this issue, just ran into it. No changes are being saved anymore.

Haven't looked deeper into the code, but the patch fixes the issue! Thank you @tBKoT! :)

#5 works

Committed, thank you for this!

@jsacksick I think I had issues yesterday with empty regions. The dragged elements landed somewhere else after saving. I guess this needs tests to compare the hidden select value set to the region name?

And for the quickfix I think it needs some more manual testing of such edge cases. Didn't have the time so far to do it, just wanted to let you know that there *might* still be issues with this.

Only tests can safe us ;)

I don't see any actual functionality change in the PR... Just "fixing" the existing code (unless I'm missing it), so it might be that the issue was present before?

@jsacksick that's possible. I'll try to reproduce it, just wanted to let you know. I dragged and dropped around a lot in the checkout flow yesterday and everything seemed to work fine except dragging into a region that was empty before. After saving, the item went into a differnet region, but I had no time to check it in detail and so I then made the changes using the "Show weights" functionality without Js through the selects.

Just wanted to let you know about the potential bug.

Without the fix from here, the whole d&d was broken as described.

You're right... Reopening this as dragging to an empty region is broken....

Thank you very much @jsacksick! 🎉

Are both patches necessary to resolve this issue?

@hockey2112 no it's fixed in the latest dev release!

Perhaps we can have a new stable?

Yes please, new release as it affects order checkout flows considerably, thank you.

New release was tagged today!

Hi @jacksick, updated to latest version, still no joy, drag is not saving.

HI @Liliplanet, did you rebuild your caches? It works perfectly for me and the fix was confirmed by 2 other people at least in this issue?

Hi @jacksick, yes thank you. Yes I updated via composer (with all dependencies), rebuilt cache, still not saving.

Hi @jacksick, awesome news. I just upgrade D10 and it fixed, drag and drop saves beautifully, thank you!

Automatically closed - issue fixed for 2 weeks with no activity.